feat: add types export#537
Merged
mikesposito merged 4 commits intomainfrom Sep 22, 2025
Merged
Conversation
Gudahtt
reviewed
Sep 22, 2025
| - `SmartTransaction` | ||
| - `SmartTransactionCancellationReason` | ||
| - `SmartTransactionStatuses` | ||
| - `APIType` |
Member
There was a problem hiding this comment.
Maybe better to remove the type exports that we don't see uses of yet, unless you think they'll be especially stable and/or useful to expose. Just so that we can minimize the chances of a breaking change in the future if they require a notification.
github-merge-queue Bot
pushed a commit
to MetaMask/metamask-mobile
that referenced
this pull request
Oct 7, 2025
…20152) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> Bumping `@metamask/smart-transactions-controller`: ```markdown ## [19.2.0] ### Added - Add missing constants and helpers exports ([#538](MetaMask/smart-transactions-controller#538)) - `MetaMetricsEventCategory` - `MetaMetricsEventName` - `getSmartTransactionMetricsProperties` - `getSmartTransactionMetricsSensitiveProperties` ## [19.1.0] ### Added - Add missing exports for types ([#537](MetaMask/smart-transactions-controller#537)) - `Fee` - `Fees` - `IndividualTxFees` - `FeatureFlags` - `SmartTransactionMinedTx` - `SmartTransaction` - `SmartTransactionCancellationReason` - `SmartTransactionStatuses` - `ClientId` ## [19.0.0] ### Added - This package can now be used in ESM environments as well as CommonJS ([#469](MetaMask/smart-transactions-controller#469)) - Add two new controller state metadata properties: `includeInStateLogs` and `usedInUi` ([#531](MetaMask/smart-transactions-controller#531)) ### Changed - **BREAKING:** Disallow subpath exports ([#469](MetaMask/smart-transactions-controller#469)) - **BREAKING:** Upgrade peer dependency `@metamask/transaction-controller` from `^58.0.0` to `^60.4.0` ([#532](MetaMask/smart-transactions-controller#532), [#534](MetaMask/smart-transactions-controller#534)) - **BREAKING:** Remove `getNonceLock`, `confirmExternalTransaction`, `getTransactions`, and `updateTransaction` constructor option in favor of messenger actions ([#534](MetaMask/smart-transactions-controller#534)) - The messenger is now used to access TransactionController; you must add these actions to the SmartTransactionController messenger allowlist: - `TransactionController:getNonceLock` - `TransactionController:confirmExternalTransaction` - `TransactionController:getTransactions` - `TransactionController:updateTransaction` - Upgrade `@metamask/base-controller` from `^7.0.1` to `^8.3.0` ([#529](MetaMask/smart-transactions-controller#529)) - Upgrade `@metamask/polling-controller` from `^12.0.0` to `^14.0.0` ([#529](MetaMask/smart-transactions-controller#529)) ### Removed - **BREAKING:** Remove default export ([#535](MetaMask/smart-transactions-controller#535)) - Use `import { SmartTransactionsController } from '@metamask/smart-transactions-controller'` instead. ``` ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: null ## **Related issues** Fixes: ## **Manual testing steps** ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Upgrades Smart Transactions to ^19.2.1 and Transaction Controller to ^60.4.0, replaces subpath/type imports, migrates Engine/messaging integration, and updates related hooks, views, selectors, and tests. > > - **Dependencies**: > - Bump `@metamask/smart-transactions-controller` to `^19.2.1` and `@metamask/transaction-controller` to `^60.4.0` (lockfile updated). > - **Engine/Controllers**: > - Switch to named exports from `@metamask/smart-transactions-controller`; remove default export usage. > - Migrate STX controller constructor to use messenger actions (`TransactionController:getNonceLock`, `confirmExternalTransaction`, `getTransactions`, `updateTransaction`) instead of direct callbacks; add MetaMetrics constants/util imports from root. > - Transaction Controller init: use `SmartTransactionStatuses` from root; wire STX hooks (single/batch) and metrics/notification handlers; keep pending resubmit disabled. > - **App code updates**: > - Replace all `@metamask/smart-transactions-controller/dist/...` imports with root package exports (types, enums like `SmartTransaction`, `SmartTransactionStatuses`, `Fee/Fees`). > - Update Swaps (QuotesView, useSwapsSmartTransaction), UnifiedTransactionsView, SmartTransactionStatus components/tests, NotificationsManager, selectors, migrations, and smart-transactions utils/hooks to new exports. > - **Tests**: > - Adapt tests to new controller exports and messenger permissions for STX hooks; minor Hex import fixes. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 3c62faf. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: Mark Stacey <markjstacey@gmail.com>
infiniteflower
pushed a commit
to MetaMask/metamask-mobile
that referenced
this pull request
Oct 7, 2025
…20152) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> Bumping `@metamask/smart-transactions-controller`: ```markdown ## [19.2.0] ### Added - Add missing constants and helpers exports ([#538](MetaMask/smart-transactions-controller#538)) - `MetaMetricsEventCategory` - `MetaMetricsEventName` - `getSmartTransactionMetricsProperties` - `getSmartTransactionMetricsSensitiveProperties` ## [19.1.0] ### Added - Add missing exports for types ([#537](MetaMask/smart-transactions-controller#537)) - `Fee` - `Fees` - `IndividualTxFees` - `FeatureFlags` - `SmartTransactionMinedTx` - `SmartTransaction` - `SmartTransactionCancellationReason` - `SmartTransactionStatuses` - `ClientId` ## [19.0.0] ### Added - This package can now be used in ESM environments as well as CommonJS ([#469](MetaMask/smart-transactions-controller#469)) - Add two new controller state metadata properties: `includeInStateLogs` and `usedInUi` ([#531](MetaMask/smart-transactions-controller#531)) ### Changed - **BREAKING:** Disallow subpath exports ([#469](MetaMask/smart-transactions-controller#469)) - **BREAKING:** Upgrade peer dependency `@metamask/transaction-controller` from `^58.0.0` to `^60.4.0` ([#532](MetaMask/smart-transactions-controller#532), [#534](MetaMask/smart-transactions-controller#534)) - **BREAKING:** Remove `getNonceLock`, `confirmExternalTransaction`, `getTransactions`, and `updateTransaction` constructor option in favor of messenger actions ([#534](MetaMask/smart-transactions-controller#534)) - The messenger is now used to access TransactionController; you must add these actions to the SmartTransactionController messenger allowlist: - `TransactionController:getNonceLock` - `TransactionController:confirmExternalTransaction` - `TransactionController:getTransactions` - `TransactionController:updateTransaction` - Upgrade `@metamask/base-controller` from `^7.0.1` to `^8.3.0` ([#529](MetaMask/smart-transactions-controller#529)) - Upgrade `@metamask/polling-controller` from `^12.0.0` to `^14.0.0` ([#529](MetaMask/smart-transactions-controller#529)) ### Removed - **BREAKING:** Remove default export ([#535](MetaMask/smart-transactions-controller#535)) - Use `import { SmartTransactionsController } from '@metamask/smart-transactions-controller'` instead. ``` ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: null ## **Related issues** Fixes: ## **Manual testing steps** ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Upgrades Smart Transactions to ^19.2.1 and Transaction Controller to ^60.4.0, replaces subpath/type imports, migrates Engine/messaging integration, and updates related hooks, views, selectors, and tests. > > - **Dependencies**: > - Bump `@metamask/smart-transactions-controller` to `^19.2.1` and `@metamask/transaction-controller` to `^60.4.0` (lockfile updated). > - **Engine/Controllers**: > - Switch to named exports from `@metamask/smart-transactions-controller`; remove default export usage. > - Migrate STX controller constructor to use messenger actions (`TransactionController:getNonceLock`, `confirmExternalTransaction`, `getTransactions`, `updateTransaction`) instead of direct callbacks; add MetaMetrics constants/util imports from root. > - Transaction Controller init: use `SmartTransactionStatuses` from root; wire STX hooks (single/batch) and metrics/notification handlers; keep pending resubmit disabled. > - **App code updates**: > - Replace all `@metamask/smart-transactions-controller/dist/...` imports with root package exports (types, enums like `SmartTransaction`, `SmartTransactionStatuses`, `Fee/Fees`). > - Update Swaps (QuotesView, useSwapsSmartTransaction), UnifiedTransactionsView, SmartTransactionStatus components/tests, NotificationsManager, selectors, migrations, and smart-transactions utils/hooks to new exports. > - **Tests**: > - Adapt tests to new controller exports and messenger permissions for STX hooks; minor Hex import fixes. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 3c62faf. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: Mark Stacey <markjstacey@gmail.com>
weitingsun
pushed a commit
to MetaMask/metamask-mobile
that referenced
this pull request
Oct 15, 2025
…20152) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> Bumping `@metamask/smart-transactions-controller`: ```markdown ## [19.2.0] ### Added - Add missing constants and helpers exports ([#538](MetaMask/smart-transactions-controller#538)) - `MetaMetricsEventCategory` - `MetaMetricsEventName` - `getSmartTransactionMetricsProperties` - `getSmartTransactionMetricsSensitiveProperties` ## [19.1.0] ### Added - Add missing exports for types ([#537](MetaMask/smart-transactions-controller#537)) - `Fee` - `Fees` - `IndividualTxFees` - `FeatureFlags` - `SmartTransactionMinedTx` - `SmartTransaction` - `SmartTransactionCancellationReason` - `SmartTransactionStatuses` - `ClientId` ## [19.0.0] ### Added - This package can now be used in ESM environments as well as CommonJS ([#469](MetaMask/smart-transactions-controller#469)) - Add two new controller state metadata properties: `includeInStateLogs` and `usedInUi` ([#531](MetaMask/smart-transactions-controller#531)) ### Changed - **BREAKING:** Disallow subpath exports ([#469](MetaMask/smart-transactions-controller#469)) - **BREAKING:** Upgrade peer dependency `@metamask/transaction-controller` from `^58.0.0` to `^60.4.0` ([#532](MetaMask/smart-transactions-controller#532), [#534](MetaMask/smart-transactions-controller#534)) - **BREAKING:** Remove `getNonceLock`, `confirmExternalTransaction`, `getTransactions`, and `updateTransaction` constructor option in favor of messenger actions ([#534](MetaMask/smart-transactions-controller#534)) - The messenger is now used to access TransactionController; you must add these actions to the SmartTransactionController messenger allowlist: - `TransactionController:getNonceLock` - `TransactionController:confirmExternalTransaction` - `TransactionController:getTransactions` - `TransactionController:updateTransaction` - Upgrade `@metamask/base-controller` from `^7.0.1` to `^8.3.0` ([#529](MetaMask/smart-transactions-controller#529)) - Upgrade `@metamask/polling-controller` from `^12.0.0` to `^14.0.0` ([#529](MetaMask/smart-transactions-controller#529)) ### Removed - **BREAKING:** Remove default export ([#535](MetaMask/smart-transactions-controller#535)) - Use `import { SmartTransactionsController } from '@metamask/smart-transactions-controller'` instead. ``` ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: null ## **Related issues** Fixes: ## **Manual testing steps** ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Upgrades Smart Transactions to ^19.2.1 and Transaction Controller to ^60.4.0, replaces subpath/type imports, migrates Engine/messaging integration, and updates related hooks, views, selectors, and tests. > > - **Dependencies**: > - Bump `@metamask/smart-transactions-controller` to `^19.2.1` and `@metamask/transaction-controller` to `^60.4.0` (lockfile updated). > - **Engine/Controllers**: > - Switch to named exports from `@metamask/smart-transactions-controller`; remove default export usage. > - Migrate STX controller constructor to use messenger actions (`TransactionController:getNonceLock`, `confirmExternalTransaction`, `getTransactions`, `updateTransaction`) instead of direct callbacks; add MetaMetrics constants/util imports from root. > - Transaction Controller init: use `SmartTransactionStatuses` from root; wire STX hooks (single/batch) and metrics/notification handlers; keep pending resubmit disabled. > - **App code updates**: > - Replace all `@metamask/smart-transactions-controller/dist/...` imports with root package exports (types, enums like `SmartTransaction`, `SmartTransactionStatuses`, `Fee/Fees`). > - Update Swaps (QuotesView, useSwapsSmartTransaction), UnifiedTransactionsView, SmartTransactionStatus components/tests, NotificationsManager, selectors, migrations, and smart-transactions utils/hooks to new exports. > - **Tests**: > - Adapt tests to new controller exports and messenger permissions for STX hooks; minor Hex import fixes. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 3c62faf. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: Mark Stacey <markjstacey@gmail.com>
github-merge-queue Bot
pushed a commit
to MetaMask/metamask-extension
that referenced
this pull request
Oct 16, 2025
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> Bumping `@metamask/smart-transactions-controller`: ```markdown ## [19.2.0] ### Added - Add missing constants and helpers exports ([#538](MetaMask/smart-transactions-controller#538)) - `MetaMetricsEventCategory` - `MetaMetricsEventName` - `getSmartTransactionMetricsProperties` - `getSmartTransactionMetricsSensitiveProperties` ## [19.1.0] ### Added - Add missing exports for types ([#537](MetaMask/smart-transactions-controller#537)) - `Fee` - `Fees` - `IndividualTxFees` - `FeatureFlags` - `SmartTransactionMinedTx` - `SmartTransaction` - `SmartTransactionCancellationReason` - `SmartTransactionStatuses` - `ClientId` ## [19.0.0] ### Added - This package can now be used in ESM environments as well as CommonJS ([#469](MetaMask/smart-transactions-controller#469)) - Add two new controller state metadata properties: `includeInStateLogs` and `usedInUi` ([#531](MetaMask/smart-transactions-controller#531)) ### Changed - **BREAKING:** Disallow subpath exports ([#469](MetaMask/smart-transactions-controller#469)) - **BREAKING:** Upgrade peer dependency `@metamask/transaction-controller` from `^58.0.0` to `^60.4.0` ([#532](MetaMask/smart-transactions-controller#532), [#534](MetaMask/smart-transactions-controller#534)) - **BREAKING:** Remove `getNonceLock`, `confirmExternalTransaction`, `getTransactions`, and `updateTransaction` constructor option in favor of messenger actions ([#534](MetaMask/smart-transactions-controller#534)) - The messenger is now used to access TransactionController; you must add these actions to the SmartTransactionController messenger allowlist: - `TransactionController:getNonceLock` - `TransactionController:confirmExternalTransaction` - `TransactionController:getTransactions` - `TransactionController:updateTransaction` - Upgrade `@metamask/base-controller` from `^7.0.1` to `^8.3.0` ([#529](MetaMask/smart-transactions-controller#529)) - Upgrade `@metamask/polling-controller` from `^12.0.0` to `^14.0.0` ([#529](MetaMask/smart-transactions-controller#529)) ### Removed - **BREAKING:** Remove default export ([#535](MetaMask/smart-transactions-controller#535)) - Use `import { SmartTransactionsController } from '@metamask/smart-transactions-controller'` instead. ``` [](https://codespaces.new/MetaMask/metamask-extension/pull/36167?quickstart=1) ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: null ## **Related issues** Fixes: ## **Manual testing steps** 1. Checkout this branch 2. Try submitting a smart transaction ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Upgrades `@metamask/smart-transactions-controller` to v19.2.1, replaces deprecated default/subpath imports, and shifts TransactionController integration to messenger-based actions with updated allowlists and tests. > > - **Smart Transactions Controller upgrade** > - Bump `@metamask/smart-transactions-controller` to `^19.2.1` and align with ESM/no-default export (remove subpath imports like `dist/types`). > - **Messenger-based integration** > - Add TransactionController actions to `SmartTransactionsController` messenger allowlist: `getNonceLock`, `confirmExternalTransaction`, `getTransactions`, `updateTransaction` in `controller-init/messengers/smart-transactions-controller-messenger.ts`. > - Refactor `SmartTransactionsControllerInit` to stop passing `getNonceLock`, `confirmExternalTransaction`, `getTransactions`, `updateTransaction` via constructor; rely on messenger; update constructor typing to use restricted `messenger` directly. > - Remove/adjust related unit tests that asserted constructor-wired functions; keep MetaMetrics wiring tests. > - **Import and type updates** > - Switch all imports to named exports from `@metamask/smart-transactions-controller` (e.g., `SmartTransactionsController`, `SmartTransactionStatuses`, `SmartTransaction`, `ClientId`, `IndividualTxFees`, etc.). > - **Policy updates** > - Update LavaMoat policies to reflect new polling-controller pathing and minor globals; adjust dependencies accordingly. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 74fa4dd. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: Mark Stacey <mark.stacey@consensys.net> Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
](https://codespaces.new/MetaMask/metamask-extension/pull/36167?quickstart=1){kind=link}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding missing exports from
types.tstoindex.tsexports.