fix: Remove an unnecessary confirmExternalTransaction call

[dan437]

Description

The TransactionController.confirmExternalTransaction call is no longer needed, since all transactions from the extension and mobile are submitted via the TransactionController and not directly via the SmartTransactionsController.submitSignedTransactions function.

Fixes MetaMask/metamask-extension#37419

---

Note

SmartTransactionsController now self-confirms STX via receipt check, removing TransactionController.confirmExternalTransaction and related history utilities; tests and coverage config updated accordingly.

• SmartTransactionsController:
  • Remove calls to TransactionController:confirmExternalTransaction and #doesTransactionNeedConfirmation.
  • Simplify #confirmSmartTransaction to check eth_getTransactionReceipt and mark confirmed: true, then publish smartTransactionConfirmationDone.
  • Emit smartTransaction earlier to surface txHash and keep regular-tx failure handling intact.
• Utils:
  • Delete history helpers (generateHistoryEntry, replayHistory, snapshotFromTxMeta) and drop fast-json-patch usage.
• Tests:
  • Remove wiring/mocks for confirmExternalTransaction; update EthQuery mock to handle empty txHash.
  • Add/adjust tests to assert confirmation on SUCCESS/REVERTED and no confirmation without minedHash.
  • Minor polling test tweaks and lint suppressions for floating promises.
• Config:
  • Exclude ./src/index.ts from coverage in jest.config.js.

^{Written by Cursor Bugbot for commit 2232933. This will update automatically on new commits. Configure here.}