fix: Mark multiple transactions as failed if a batch smart transaction fails

[dan437]

Description

fix: Mark multiple transactions as failed if a batch smart transaction fails.

Steps to reproduce

Quickest way is to upgrade or downgrade an EIP-7702 account and use any gas fee token, with STX enabled (this error is being fixed separately by @matthewwalsh0).

Before this fix only one transaction from a batch would be marked as failed, with this all transactions in a batch are marked as failed. It only started happening after we started returning a txHash asap. Before that all transactions were being marked as failed in the TransactionController.

---

Note

Marks all related regular transactions as failed when a batch smart transaction fails by matching txHashes, updates controller usage, and adds tests; also records txHashes on submit (keeping legacy txHash).

• Smart transactions logic:
  • Rename shouldMarkRegularTransactionAsFailed → shouldMarkRegularTransactionsAsFailed and markRegularTransactionAsFailed → markRegularTransactionsAsFailed.
  • Update failure handling to mark multiple regular TransactionMeta as failed by matching tx.hash in smartTransaction.txHashes or id equals transactionId; skip already-failed.
• Controller:
  • Use new pluralized helpers to decide and apply failure updates.
  • On submit, compute and store txHashes (and keep txHash for backward compatibility).
• Tests:
  • Update test names and expectations; add case asserting multiple transactions are marked failed when txHashes match.

^{Written by Cursor Bugbot for commit 2b8334b. This will update automatically on new commits. Configure here.}