feat: Add onAssetHistoricalPrice handler#3282
Merged
GuillaumeRx merged 10 commits intomainfrom Apr 3, 2025
Merged
Conversation
GuillaumeRx
commented
Mar 31, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3282 +/- ##
=======================================
Coverage 94.87% 94.88%
=======================================
Files 517 518 +1
Lines 11336 11357 +21
Branches 1750 1752 +2
=======================================
+ Hits 10755 10776 +21
Misses 581 581 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Apr 1, 2025
This PR moves 2 refiners related to ISO 8601 time strings to `snaps-utils`, this allows the refiner to be used in other places (required for #3282).
GuillaumeRx
force-pushed
the
gr/on-asset-historical-price
branch
from
a74acb4 to
4238235
Compare
GuillaumeRx
force-pushed
the
gr/on-asset-historical-price
branch
from
b357b29 to
1063f83
Compare
GuillaumeRx
force-pushed
the
gr/on-asset-historical-price
branch
from
d75399f to
40c42d8
Compare
FrederikBolding
approved these changes
Apr 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new handler called
onAssetHistoricalPrice.Small updates bundled in this PR:
assertRequestArgumentsin the execution-environment validation to remove code duplication.Progresses: #3229