revert: "chore!: Remove web worker execution service and environment (#3357)"#3359
Merged
revert: "chore!: Remove web worker execution service and environment (#3357)"#3359
Conversation
FrederikBolding
approved these changes
Apr 28, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3359 +/- ##
==========================================
- Coverage 98.04% 98.03% -0.01%
==========================================
Files 398 402 +4
Lines 10953 11109 +156
Branches 1725 1754 +29
==========================================
+ Hits 10739 10891 +152
- Misses 214 218 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-merge-queue Bot
pushed a commit
that referenced
this pull request
May 2, 2025
This is a redo of #3357, which was reverted in #3359 to avoid two breaking changes in a row. Now that #3322 is merged, we can do this again. The original PR description can be found below. --- This removes the web worker execution service and execution environment, as they were unused. We can revert this PR in the future to add them again, if needed. ## Breaking changes ### `@metamask/snaps-controllers` - Remove web worker execution service. ### `@metamask/snaps-execution-environments` - Remove web worker pool execution environment. - Remove web worker executor execution environment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 042d2fa.
To avoid multiple major releases shortly after each other, we should group this closer with the merge of #3322.