chore!: Remove web worker execution service and environment#3371
Merged
chore!: Remove web worker execution service and environment#3371
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3371 +/- ##
========================================
Coverage 98.03% 98.04%
========================================
Files 402 398 -4
Lines 11107 10951 -156
Branches 1754 1725 -29
========================================
- Hits 10889 10737 -152
+ Misses 218 214 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
FrederikBolding
approved these changes
May 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a redo of #3357, which was reverted in #3359 to avoid two breaking changes in a row. Now that #3322 is merged, we can do this again.
The original PR description can be found below.
This removes the web worker execution service and execution environment, as they were unused. We can revert this PR in the future to add them again, if needed.
Breaking changes
@metamask/snaps-controllers@metamask/snaps-execution-environments