Merge branch 'hotfix/fix_migration_table_exist' into 'feature/2.3.0'

Hotfix/fix migration table exist

See merge request metamodels/attribute_select!109

Author: zonky2

src/Migration/AllowNullMigration.php

@@ -29,6 +29,11 @@
 use Doctrine\DBAL\Schema\Column;
 use Doctrine\DBAL\Schema\SchemaException;
 
+use function array_intersect;
+use function array_map;
+use function count;
+use function implode;
+
 /**
  * This migration changes all database columns to allow null values.
  *
@@ -43,6 +48,9 @@ class AllowNullMigration extends AbstractMigration
      */
     private Connection $connection;
 
+    /** @var list<string> */
+    private array $existsCache = [];
+
     /**
      * Create a new instance.
      *
@@ -73,9 +81,7 @@ public function getName(): string
      */
     public function shouldRun(): bool
     {
-        $schemaManager = $this->connection->createSchemaManager();
-
-        if (!$schemaManager->tablesExist(['tl_metamodel', 'tl_metamodel_attribute'])) {
+        if (!$this->tablesExist(['tl_metamodel', 'tl_metamodel_attribute'])) {
             return false;
         }
 
@@ -103,7 +109,7 @@ public function run(): MigrationResult
             }
         }
 
-        return new MigrationResult(true, 'Adjusted column(s): ' . \implode(', ', $message));
+        return new MigrationResult(true, 'Adjusted column(s): ' . implode(', ', $message));
     }
 
     /**
@@ -121,6 +127,10 @@ private function fetchNonNullableColumns(): array
 
         $result = [];
         foreach ($langColumns as $tableName => $tableColumnNames) {
+            if (!$this->tablesExist([$tableName])) {
+                continue;
+            }
+
             /** @var Column[] $columns */
             $columns = [];
             // The schema manager return the column list with lowercase keys, wo got to use the real names.
@@ -205,4 +215,13 @@ private function fixColumn(string $tableName, Column $column): void
             ->where('t.' . $column->getName() . ' = 0')
             ->executeQuery();
     }
+
+    private function tablesExist(array $tableNames): bool
+    {
+        if ([] === $this->existsCache) {
+            $this->existsCache = \array_values($this->connection->createSchemaManager()->listTableNames());
+        }
+
+        return count($tableNames) === count(array_intersect($tableNames, array_map('strtolower', $this->existsCache)));
+    }
 }

tests/Migration/AllowNullMigrationTest.php

@@ -56,15 +56,15 @@ public function runConfiguration(): \Generator
             ]
         ];
 
-        yield 'attribute select not configured' => [
+        yield 'attribute not configured' => [
             (object) [
                 'requiredTablesExist' => true,
                 'shouldRun'           => false,
                 'attributeConfigured' => false
             ]
         ];
 
-        yield 'attribute select is configured' => [
+        yield 'attribute is configured' => [
             (object) [
                 'requiredTablesExist' => true,
                 'shouldRun'           => false,
@@ -97,14 +97,17 @@ public function testRun(object $configuration): void
         $manager    = $this
             ->getMockBuilder(AbstractSchemaManager::class)
             ->setConstructorArgs([$connection, $plattform])
-            ->onlyMethods(['tablesExist', 'introspectTable', 'alterTable'])
+            ->onlyMethods(['listTableNames', 'introspectTable', 'alterTable'])
             ->getMockForAbstractClass();
 
         $manager
             ->expects(self::once())
-            ->method('tablesExist')
-            ->with(['tl_metamodel', 'tl_metamodel_attribute'])
-            ->willReturn($configuration->requiredTablesExist);
+            ->method('listTableNames')
+            ->willReturn(
+                $configuration->requiredTablesExist
+                    ? ['tl_metamodel', 'tl_metamodel_attribute', 'mm_table_1', 'mm_table_2']
+                    : []
+            );
 
         $connection
             ->expects(