Wrong TypeHinting in CustomSql

[bezin]

Continuing from here to not further flood the Core-Bundle issue tracker contao/core-bundle#1603

Unfortunately it is not fixed yet. Event-Dispatcher works again, but now I cannot access filter configuration in the backend. I get the following error message:

Type error: Argument 4 passed to MetaModels\Filter\Setting\CustomSql::__construct() must be an instance of Contao\InsertTags, instance of Contao\CoreBundle\Framework\Adapter given, called in C:\dev\web\metamodels\vendor\metamodels\core\src\Filter\Setting\CustomSqlFilterSettingTypeFactory.php on line 105

This is due to TypeHinting in CustomSql.php:114, where Contao\InsertTags still is expected.

Cheers

[bezin]

Hello there,

I further debugged this: The definition of the metamodels.insert_tags service needs to be fixed as well. The class name should not be escaped, because it gets escaped afterwards during container build, hence escaping it prior leads to "Contao\\InsertTags" being passed to the Adapter.

However, the InsertTags classes needs do be passed in as an instance anyways, because the replace method calls $this->doReplace().

[zonky2]

@discordier can you check this?

[discordier]

Try 2f1d8db please

[bezin]

This does fix it 👍 Many thanks 🙌

[zonky2]

thx