SCSS#1262
Closed
kikmedia wants to merge 3 commits into
Closed
Conversation
added 3 commits
January 14, 2019 18:23
Fixed Metamodels URL, switched to https
Closed
discordier
requested changes
Jan 14, 2019
Member
discordier
left a comment
discordier
left a comment
There was a problem hiding this comment.
First off, thanks for tackling this.
I think we should switch from tab to space indention for the scss, opinions?
IMO the generated css should also be minified.
| font-weight: bold; | ||
| } | ||
| } | ||
| body[class*="version_2"] { |
Member
There was a problem hiding this comment.
I wonder if this is really still needed as we are Version 3/4 now.
Contributor
There was a problem hiding this comment.
I think we can delete all body[class*="version_N"] {
Contributor
Author
There was a problem hiding this comment.
You are absolutely right. I will update the PR tomorrow.
zonky2
added
the
enhancement
Contributor
|
all fixed in #1286 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added SCSS files, removed unused *src.css files, switched support screen image url to https
Checklist
@authorsin touched PHP files