Skip to content
This repository was archived by the owner on Mar 14, 2019. It is now read-only.

Fixing issue 731 & 408#914

Open
louis49 wants to merge 3 commits into
Meteor-Community-Packages:masterfrom
louis49:solution2
Open

Fixing issue 731 & 408#914
louis49 wants to merge 3 commits into
Meteor-Community-Packages:masterfrom
louis49:solution2

Conversation

@louis49

@louis49 louis49 commented Jan 22, 2016

Copy link
Copy Markdown

No description provided.

@YannDanthu

Copy link
Copy Markdown

+1

@ChrisCinelli

Copy link
Copy Markdown
Contributor

Does this fix #725 too?
This was definitely where it was crashing: https://github.com/CollectionFS/Meteor-CollectionFS/pull/914/files#diff-3a71c936b7fa3ece7c136a01afc0d6a3L297

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part is pretty straight forward. What is unclear is when we get in the condition where temp is empty. @louis49 do you have something to add here?

@ericoe

ericoe commented May 12, 2017

Copy link
Copy Markdown

Hey guys, what is the status on this? Looks like the pull request was never approved. Are you running this code with success?

@nooitaf

nooitaf commented Dec 4, 2017

Copy link
Copy Markdown
Contributor

This seems to be about sharding and multinode setups?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants