Release 3.4.0#196
Open
nachocodoner wants to merge 6 commits into
Open
Conversation
In Meteor 3.x, async startup callbacks and top-level await can cause mocha.run() to fire before all Meteor.startup() callbacks have completed. This leads to flaky tests when server initialization depends on async startup work (e.g. ensuring MongoDB indices). Await a promise resolved by a Meteor.startup() callback at the end of the queue, ensuring all prior callbacks (including async ones) have finished before tests begin. Fixes #176 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Adds a server test that registers an async Meteor.startup() callback with a short delay and asserts it completed before tests run. Without the fix in server.js, mocha.run() fires before the callback finishes, causing this test to fail. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
4 tasks
fix: await Meteor.startup() queue before running tests
Member
Author
|
@jankapunkt, @StorytellerCZ: I need to publish a beta of this package, but I don't seem to have permission in my Meteor user. Do you have ways to publish or give me permissions to do it? |
Member
|
@nachocodoner I published |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include