Skip to content

Meteor 3#183

Open
StorytellerCZ wants to merge 27 commits into
masterfrom
feature/meteor-3
Open

Meteor 3#183
StorytellerCZ wants to merge 27 commits into
masterfrom
feature/meteor-3

Conversation

@StorytellerCZ
Copy link
Copy Markdown
Member

@StorytellerCZ StorytellerCZ commented Feb 28, 2024

  • all code transformed to async
  • full Fibers removal
  • updated all deps / dev deps in package.js to Meteor 3 compatible versions
  • update CI to GitHub actions
  • drop Travis CI
  • update documentation
  • check integration with fix for meteor version 3 #203

Releases

  • alpha
  • beta
  • RC
  • release

Copy link
Copy Markdown

@dallman2 dallman2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Very similar to the workarounds i was using locally. Please merge this

@acemtp
Copy link
Copy Markdown

acemtp commented Jun 18, 2024

Looks good., when will it be merged and a new package released?

@StorytellerCZ
Copy link
Copy Markdown
Member Author

@acemtp thanks for the ping. We'll need to look into replacing Travis, but I will try to release a beta in a few moments.

@StorytellerCZ StorytellerCZ marked this pull request as ready for review June 18, 2024 08:28
@acemtp
Copy link
Copy Markdown

acemtp commented Jun 18, 2024

Awesome, I try to clean my local patched package to be full ready for meteor 3.

I'll test the beta version as soon as available.

@StorytellerCZ
Copy link
Copy Markdown
Member Author

Published mizzao:user-status@2.0.0-beta.0

@StorytellerCZ
Copy link
Copy Markdown
Member Author

StorytellerCZ commented Jun 18, 2024

TODO:

@acemtp
Copy link
Copy Markdown

acemtp commented Jun 19, 2024

I used it on my project, it works fine! thanks for the release

@StorytellerCZ
Copy link
Copy Markdown
Member Author

Just need to update tests for async and we should be fine.

@StorytellerCZ StorytellerCZ added the need help Help is very much appreciated on this. label Jul 16, 2024
@diavrank
Copy link
Copy Markdown

diavrank commented Aug 1, 2024

Hope to test the beta version in the next few days

@wreiske
Copy link
Copy Markdown
Collaborator

wreiske commented Sep 12, 2024

@StorytellerCZ
Copy link
Copy Markdown
Member Author

@wreiske Published mizzao:user-status@2.0.0-rc.2 which should fix the issue.

@imongithubnow
Copy link
Copy Markdown

I don't understand why this great package is stuck here, also 2.0.0-rc.2 version don't works on Meteor 3, there are few points to fix to align the await/async features.
I'm sure I'm missing something but I don't understand what.

@StorytellerCZ
Copy link
Copy Markdown
Member Author

@imongithubnow it is simple, I don't have the time. PRs welcome.

@imongithubnow
Copy link
Copy Markdown

imongithubnow commented Jan 14, 2026

@imongithubnow it is simple, I don't have the time. PRs welcome.

ok this make a sense... :-)
I'm surprised that only a few changes were needed to fix it, so I don't understand why they haven't been made. I'm definitely doing something wrong... even if it works with these.
Anyway, I'll try to make a PR, out of curiosity.

@StorytellerCZ
Copy link
Copy Markdown
Member Author

@imongithubnow open the PR against this branch which will get it merged faster.

@jankapunkt
Copy link
Copy Markdown
Member

@StorytellerCZ since we dont get a quick mtest fix I would opt to move this package to mocha and biome

@imongithubnow
Copy link
Copy Markdown

@imongithubnow open the PR against this branch which will get it merged faster.

@StorytellerCZ I'm new to GitHub (as you can see ;-) ), I submitted a PR, but it fails.
2 questions:

  • Why does it fail ? It looks like a CI stack issue.
  • Unfortunately, I committed my code, and the formatting isn't the same as the original. Is this a big problem ?
    Thank you.

@imongithubnow
Copy link
Copy Markdown

@imongithubnow open the PR against this branch which will get it merged faster.

@StorytellerCZ I'm new to GitHub (as you can see ;-) ), I submitted a PR, but it fails. 2 questions:

* Why does it fail ? It looks like a CI stack issue.

* Unfortunately, I committed my code, and the formatting isn't the same as the original. Is this a big problem ?
  Thank you.

I commit good formatting code fews days ago ;-)

@jankapunkt
Copy link
Copy Markdown
Member

@imongithubnow where did you format your code? I don't see any changes here.
@StorytellerCZ should I continue this PR?

@imongithubnow
Copy link
Copy Markdown

imongithubnow commented May 5, 2026

@imongithubnow where did you format your code? I don't see any changes here. @StorytellerCZ should I continue this PR?

I did a force-pushed over my previous commit
#203

@imongithubnow
Copy link
Copy Markdown

I saw tests, obviously with Meteor version before 2.9 faileds by unsupported async/await for Nodejs, for others tests there are some troubles about Node TLS, I don't understand why.
Maybe need some more changes ?

@jankapunkt
Copy link
Copy Markdown
Member

Yeah, some things are still missing, I am making a little roadmap in the PR description and will look forward to get this all fixed up by the end of this week.

@harryadel
Copy link
Copy Markdown
Member

harryadel commented May 17, 2026

After releasing https://github.com/Meteor-Community-Packages/meteor-timesync/releases/tag/v1.0.0 I noticed it'd not be possible to maintain the duality of user-status so I decided to double down on 3.0 with 2.0.0-rc.4'.

Awaiting your take guys, if all is we good we can do a full release very soon. Good night! 😴

@harryadel harryadel requested a review from jankapunkt May 17, 2026 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

need help Help is very much appreciated on this.

Projects

None yet

9 participants