Skip to content

Meteor 3 - #183

Merged
harryadel merged 28 commits into
masterfrom
feature/meteor-3
May 19, 2026
Merged

Meteor 3#183
harryadel merged 28 commits into
masterfrom
feature/meteor-3

Conversation

@StorytellerCZ

@StorytellerCZ StorytellerCZ commented Feb 28, 2024

Copy link
Copy Markdown
Member
  • all code transformed to async
  • full Fibers removal
  • updated all deps / dev deps in package.js to Meteor 3 compatible versions
  • update CI to GitHub actions
  • drop Travis CI
  • update documentation
  • check integration with fix for meteor version 3 #203

Releases

  • alpha
  • beta
  • RC
  • release

@dallman2 dallman2 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Very similar to the workarounds i was using locally. Please merge this

@acemtp

acemtp commented Jun 18, 2024

Copy link
Copy Markdown

Looks good., when will it be merged and a new package released?

@StorytellerCZ

Copy link
Copy Markdown
Member Author

@acemtp thanks for the ping. We'll need to look into replacing Travis, but I will try to release a beta in a few moments.

@StorytellerCZ
StorytellerCZ marked this pull request as ready for review June 18, 2024 08:28
@acemtp

acemtp commented Jun 18, 2024

Copy link
Copy Markdown

Awesome, I try to clean my local patched package to be full ready for meteor 3.

I'll test the beta version as soon as available.

@StorytellerCZ

Copy link
Copy Markdown
Member Author

Published mizzao:user-status@2.0.0-beta.0

@StorytellerCZ

StorytellerCZ commented Jun 18, 2024

Copy link
Copy Markdown
Member Author

TODO:

@acemtp

acemtp commented Jun 19, 2024

Copy link
Copy Markdown

I used it on my project, it works fine! thanks for the release

@StorytellerCZ

Copy link
Copy Markdown
Member Author

Just need to update tests for async and we should be fine.

@StorytellerCZ StorytellerCZ added the need help Help is very much appreciated on this. label Jul 16, 2024
@diavrank

diavrank commented Aug 1, 2024

Copy link
Copy Markdown

Hope to test the beta version in the next few days

@wreiske

wreiske commented Sep 12, 2024

Copy link
Copy Markdown
Collaborator

@StorytellerCZ

Copy link
Copy Markdown
Member Author

@wreiske Published mizzao:user-status@2.0.0-rc.2 which should fix the issue.

@imongithubnow

Copy link
Copy Markdown

I don't understand why this great package is stuck here, also 2.0.0-rc.2 version don't works on Meteor 3, there are few points to fix to align the await/async features.
I'm sure I'm missing something but I don't understand what.

@StorytellerCZ

Copy link
Copy Markdown
Member Author

@imongithubnow it is simple, I don't have the time. PRs welcome.

@imongithubnow

imongithubnow commented Jan 14, 2026

Copy link
Copy Markdown

@imongithubnow it is simple, I don't have the time. PRs welcome.

ok this make a sense... :-)
I'm surprised that only a few changes were needed to fix it, so I don't understand why they haven't been made. I'm definitely doing something wrong... even if it works with these.
Anyway, I'll try to make a PR, out of curiosity.

@StorytellerCZ

Copy link
Copy Markdown
Member Author

@imongithubnow open the PR against this branch which will get it merged faster.

@jankapunkt

Copy link
Copy Markdown
Member

@StorytellerCZ since we dont get a quick mtest fix I would opt to move this package to mocha and biome

@imongithubnow

Copy link
Copy Markdown

@imongithubnow open the PR against this branch which will get it merged faster.

@StorytellerCZ I'm new to GitHub (as you can see ;-) ), I submitted a PR, but it fails.
2 questions:

  • Why does it fail ? It looks like a CI stack issue.
  • Unfortunately, I committed my code, and the formatting isn't the same as the original. Is this a big problem ?
    Thank you.

@imongithubnow

Copy link
Copy Markdown

@imongithubnow open the PR against this branch which will get it merged faster.

@StorytellerCZ I'm new to GitHub (as you can see ;-) ), I submitted a PR, but it fails. 2 questions:

* Why does it fail ? It looks like a CI stack issue.

* Unfortunately, I committed my code, and the formatting isn't the same as the original. Is this a big problem ?
  Thank you.

I commit good formatting code fews days ago ;-)

@jankapunkt

Copy link
Copy Markdown
Member

@imongithubnow where did you format your code? I don't see any changes here.
@StorytellerCZ should I continue this PR?

@imongithubnow

imongithubnow commented May 5, 2026

Copy link
Copy Markdown

@imongithubnow where did you format your code? I don't see any changes here. @StorytellerCZ should I continue this PR?

I did a force-pushed over my previous commit
#203

@imongithubnow

Copy link
Copy Markdown

I saw tests, obviously with Meteor version before 2.9 faileds by unsupported async/await for Nodejs, for others tests there are some troubles about Node TLS, I don't understand why.
Maybe need some more changes ?

@jankapunkt

Copy link
Copy Markdown
Member

Yeah, some things are still missing, I am making a little roadmap in the PR description and will look forward to get this all fixed up by the end of this week.

@harryadel

harryadel commented May 17, 2026

Copy link
Copy Markdown
Member

After releasing https://github.com/Meteor-Community-Packages/meteor-timesync/releases/tag/v1.0.0 I noticed it'd not be possible to maintain the duality of user-status so I decided to double down on 3.0 with 2.0.0-rc.4'.

Awaiting your take guys, if all is we good we can do a full release very soon. Good night! 😴

@harryadel
harryadel requested a review from jankapunkt May 17, 2026 22:33
@harryadel
harryadel merged commit b97c93b into master May 19, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

need help Help is very much appreciated on this.

Projects

None yet

9 participants