Cleanup: isEmpty/empty collection checks, switch expression arrows

Author: Merennor

src/main/java/nekiplay/meteorplus/features/modules/misc/AutoAccept.java

@@ -145,7 +145,7 @@ public void onMessageReceive(ReceiveMessageEvent event) {
 					Accept(nickname, pattern, message);
 				} else {
 					nickname = getName(custom, message);
-					if (!nickname.equals("")) {
+					if (!nickname.isEmpty()) {
 						try {
 							Thread.sleep(Delay.get());
 						} catch (InterruptedException e) {
@@ -163,7 +163,7 @@ private String getName(String message) {
 		String nickname = "";
 		for (TPPattern tpPattern : patterns) {
 			String nn = getName(tpPattern, message);
-			if (!nn.equals("")) {
+			if (!nn.isEmpty()) {
 				nickname = nn;
 			}
 		}
@@ -176,7 +176,7 @@ private String getName(TPPattern tpPattern, String message) {
 		Matcher matcher = pattern.matcher(message);
 		if (matcher.find()) {
 			String player = matcher.group(tpPattern.group);
-			if (!player.equals("")) {
+			if (!player.isEmpty()) {
 				nickname = player;
 			}
 		}
@@ -189,7 +189,7 @@ private TPPattern getPattern(String message) {
 			Matcher matcher = pattern.matcher(message);
 			if (matcher.find()) {
 				String player = matcher.group(tpPattern.group);
-				if (!player.equals("")) {
+				if (!player.isEmpty()) {
 					return tpPattern;
 				}
 			}

src/main/java/nekiplay/meteorplus/features/modules/world/SafeMine.java

@@ -144,7 +144,7 @@ private void onFluidCollisionShape(CollisionShapeEvent event) {
 	@EventHandler(priority = EventPriority.HIGH)
 	private void onStartBreakingBlock(StartBreakingBlockEvent event) {
 		ArrayList<BlockPos> lavaBlocks = isExposedLava(event.blockPos);
-		if (lavaBlocks.size() > 0 && antiMine.get()) {
+		if (!lavaBlocks.isEmpty() && antiMine.get()) {
 			mc.options.keyAttack.setDown(false);
 			event.setCancelled(true);
 			synchronized (lava) {

src/main/java/nekiplay/meteorplus/features/modules/world/XrayBruteforce.java

@@ -448,7 +448,7 @@ private void onTickRainbow() {
 					defaultBlockConfig.get().tickRainbow();
 					if (blockConfigs.get() != null) {
 						Collection<ESPBlockData> datas = blockConfigs.get().values();
-						if (datas.size() > 0) {
+						if (!datas.isEmpty()) {
 							for (ESPBlockData blockData : datas) {
 								if (blockData != null) {
 									blockData.tickRainbow();
@@ -666,7 +666,7 @@ public ESPBlockData getBlockData(Block block) {
 	}
 
 	private void updateRenderedOres() {
-		if (ores.size() > 0) {
+		if (!ores.isEmpty()) {
 			for (RenderOre pos : ores.toArray(new RenderOre[0])) {
 				BlockState state = mc.level.getBlockState(pos.blockPos);
 				if (state.getBlock() == pos.block) {
@@ -678,7 +678,7 @@ private void updateRenderedOres() {
 
 	private void renderOres(Render3DEvent event) {
 		int renderBlocks = 0;
-		if (ores.size() > 0) {
+		if (!ores.isEmpty()) {
 			for (RenderOre pos : ores.toArray(new RenderOre[0])) {
 				if (setColors(pos)) {
 					if (autoSave.get()) {
@@ -939,7 +939,7 @@ private ServerboundPlayerActionPacket getPacket(BlockPos blockpos, Setting<Packe
 	private void checker() {
 		float timeSinceLastTick = TickRate.INSTANCE.getTimeSinceLastTick();
 		if (LocalDateTime.now().atZone(ZoneId.systemDefault()).toInstant().toEpochMilli() >= millis && !pause_toggle) {
-			if (blocks != null && blocks.size() > 0) {
+			if (blocks != null && !blocks.isEmpty()) {
 				if (tps_sync.get() && timeSinceLastTick <= 1f) {
 					work();
 				} else if (!tps_sync.get()) {

src/main/java/nekiplay/meteorplus/features/modules/world/autoobsidianmine/AutoObsidianFarm.java

@@ -169,9 +169,7 @@ private void onModeChanged(AutoObsidianFarmModes mode) {
 					error("This mode need Baritone API (Fabric)");
 				}
 			}
-			case Cauldrons -> {
-				currentMode = new Cauldrons();
-			}
+			case Cauldrons -> currentMode = new Cauldrons();
 		}
 	}
 

src/main/java/nekiplay/meteorplus/features/modules/world/timer/TimerPlus.java

@@ -128,9 +128,7 @@ private void onTimerModeChanged(TimerModes mode) {
 				timerMultiplier = 1.25;
 				timerMultiplierOnRecharge = Timer.OFF;
 			}
-			case Vulcan -> {
-				currentMode = new Vulcan();
-			}
+			case Vulcan -> currentMode = new Vulcan();
 			case Grim -> {
 				currentMode = new NCP();
 				workingDelay = 14;

src/main/java/nekiplay/meteorplus/utils/xraybruteforce/XGroup.java

@@ -94,7 +94,7 @@ private void trySplit(XBlock block) {
 			}
 		}
 
-		if (neighbours.size() > 0) {
+		if (!neighbours.isEmpty()) {
 			XGroup group = search.newGroup(this.block);
 			group.blocks.ensureCapacity(remainingBlocks.size());