Skip to content

Commit cc6cca6

Browse files
committed
Fix GenericSetting and Vector3dSetting not calling onChanged
1 parent d1ac5dc commit cc6cca6

2 files changed

Lines changed: 17 additions & 5 deletions

File tree

src/main/java/meteordevelopment/meteorclient/gui/DefaultSettingsWidgetFactory.java

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -218,7 +218,11 @@ private void providedStringW(WTable table, ProvidedStringSetting setting) {
218218

219219
private void genericW(WTable table, GenericSetting<?> setting) {
220220
WButton edit = table.add(theme.button(GuiRenderer.EDIT)).widget();
221-
edit.action = () -> mc.setScreen(setting.get().createScreen(theme));
221+
edit.action = () -> {
222+
WidgetScreen screen = setting.get().createScreen(theme);
223+
screen.onClosed(setting::onChanged);
224+
mc.setScreen(screen);
225+
};
222226

223227
reset(table, setting, null);
224228
}
@@ -450,9 +454,15 @@ private WDoubleEdit addVectorComponent(WTable table, String label, double value,
450454

451455
WDoubleEdit component = table.add(theme.doubleEdit(value, setting.min, setting.max, setting.sliderMin, setting.sliderMax, setting.decimalPlaces, setting.noSlider)).expandX().widget();
452456
if (setting.onSliderRelease) {
453-
component.actionOnRelease = () -> update.accept(component.get());
457+
component.actionOnRelease = () -> {
458+
update.accept(component.get());
459+
setting.onChanged();
460+
};
454461
} else {
455-
component.action = () -> update.accept(component.get());
462+
component.action = () -> {
463+
update.accept(component.get());
464+
setting.onChanged();
465+
};
456466
}
457467

458468
table.row();

src/main/java/meteordevelopment/meteorclient/systems/modules/render/blockesp/ESPBlockDataScreen.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -106,8 +106,10 @@ public void initWidgets() {
106106
}
107107

108108
private void onChanged() {
109-
if (!blockData.isChanged() && block != null && setting != null) {
110-
setting.get().put(block, blockData);
109+
if (block != null && setting != null) {
110+
if (!blockData.isChanged()) {
111+
setting.get().put(block, blockData);
112+
}
111113
setting.onChanged();
112114
}
113115

0 commit comments

Comments
 (0)