Skip to content

Commit ea3dd37

Browse files
committed
Remove irrelevant or outdated todos [skip ci]
1 parent a292755 commit ea3dd37

4 files changed

Lines changed: 2 additions & 7 deletions

File tree

src/main/java/meteordevelopment/meteorclient/gui/screens/ContainerInventoryScreen.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
import static meteordevelopment.meteorclient.MeteorClient.mc;
3030

3131
/*
32-
* i couldn't figure out how to add proper outer borders for the GUI without adding custom textures. @TODO
32+
* i couldn't figure out how to add proper outer borders for the GUI without adding custom textures.
3333
*/
3434
public class ContainerInventoryScreen extends Screen {
3535
private static final Identifier SLOT_TEXTURE = Identifier.ofVanilla("container/slot");

src/main/java/meteordevelopment/meteorclient/gui/widgets/containers/WView.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ public void onMouseMoved(double mouseX, double mouseY, double lastMouseX, double
110110

111111
//scroll += Math.round(theme.scale(mouseDelta + mouseDelta * ((height / actualHeight) * 0.7627725)));
112112
//scroll += Math.round(theme.scale(mouseDelta * (1 / (height / actualHeight))));
113-
scroll += Math.round(mouseDelta * ((actualHeight - handleHeight() / 2) / height)); // TODO: Someone improve this
113+
scroll += Math.round(mouseDelta * ((actualHeight - handleHeight() / 2) / height));
114114
scroll = MathHelper.clamp(scroll, 0, actualHeight - height);
115115

116116
targetScroll = scroll;

src/main/java/meteordevelopment/meteorclient/mixin/ItemEntityRendererMixin.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ public abstract class ItemEntityRendererMixin {
3030

3131
@Inject(method = "render(Lnet/minecraft/client/render/entity/state/ItemEntityRenderState;Lnet/minecraft/client/util/math/MatrixStack;Lnet/minecraft/client/render/command/OrderedRenderCommandQueue;Lnet/minecraft/client/render/state/CameraRenderState;)V", at = @At("HEAD"), cancellable = true)
3232
private void renderStack(ItemEntityRenderState itemEntityRenderState, MatrixStack matrixStack, OrderedRenderCommandQueue orderedRenderCommandQueue, CameraRenderState arg, CallbackInfo ci) {
33-
// todo fix to work with entity render batching
3433
RenderItemEntityEvent event = MeteorClient.EVENT_BUS.post(RenderItemEntityEvent.get(itemEntityRenderState, mc.getRenderTickCounter().getTickProgress(true), matrixStack, null, itemEntityRenderState.light, this.itemModelManager, orderedRenderCommandQueue));
3534
if (event.isCancelled()) ci.cancel();
3635
}

src/main/java/meteordevelopment/meteorclient/utils/Utils.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -246,7 +246,6 @@ public static boolean openContainer(ItemStack itemStack, ItemStack[] contents, b
246246
return false;
247247
}
248248

249-
@SuppressWarnings("deprecation") // Use of NbtCompound#getNbt
250249
public static void getItemsInContainerItem(ItemStack itemStack, ItemStack[] items) {
251250
if (itemStack.getItem() == Items.ENDER_CHEST) {
252251
for (int i = 0; i < EChestMemory.ITEMS.size(); i++) {
@@ -267,8 +266,6 @@ public static void getItemsInContainerItem(ItemStack itemStack, ItemStack[] item
267266
if (i >= 0 && i < items.length) items[i] = stacks.get(i);
268267
}
269268
}
270-
// todo should we remove this? are there still instances where we might get presented container items in this
271-
// format? maybe on servers with weird multiversion setups - if they exist, test this code to ensure it works
272269
else if (components.contains(DataComponentTypes.BLOCK_ENTITY_DATA)) {
273270
TypedEntityData<BlockEntityType<?>> blockEntityData = components.get(DataComponentTypes.BLOCK_ENTITY_DATA);
274271
if (blockEntityData == null) return;
@@ -310,7 +307,6 @@ public static Color getShulkerColor(ItemStack shulkerItem) {
310307
return WHITE;
311308
}
312309

313-
@SuppressWarnings("deprecation") // Use of NbtCompound#getNbt
314310
public static boolean hasItems(ItemStack itemStack) {
315311
ContainerComponentAccessor container = ((ContainerComponentAccessor) (Object) itemStack.get(DataComponentTypes.CONTAINER));
316312
if (container != null && !container.meteor$getStacks().isEmpty()) return true;

0 commit comments

Comments
 (0)