Skip to content

Surround improvements#5459

Merged
Wide-Cat merged 6 commits into
MeteorDevelopment:masterfrom
Gingerbeard5773:surround-improvement
Sep 25, 2025
Merged

Surround improvements#5459
Wide-Cat merged 6 commits into
MeteorDevelopment:masterfrom
Gingerbeard5773:surround-improvement

Conversation

@Gingerbeard5773

@Gingerbeard5773 Gingerbeard5773 commented Jun 4, 2025

Copy link
Copy Markdown
Contributor

Type of change

  • Bug fix
  • New feature

Description

  • Added Air Place setting for servers that don't allow air place.
  • Added Blocks Per Tick setting to allow for more blocks to be placed per tick, which means instant/faster placement on applicable servers.

Related issues

resolves #3474, resolves #900, resolves #844, resolves #3691, partially addresses #2930

How Has This Been Tested?

Minecraft_.1.21.4.-.Singleplayer.2025-06-04.00-16-48.mp4

I also tested blocks per tick on Constantiam and was able to get 4 blocks per tick (instant placement)

Checklist:

  • My code follows the style guidelines of this project.
  • I have added comments to my code in more complex areas.
  • I have tested the code in both development and production environments.

* Added air place option for servers that don't allow air place

* Added blocks per tick setting to allow for more blocks to be placed per tick.
@Gingerbeard5773

Copy link
Copy Markdown
Contributor Author

Updated to 1.21.8, waiting for review

@Wide-Cat Wide-Cat left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you have a high blocks per tick value it often doesn't center the player properly, leading to your surround being half built. It seems to be because it tries to place all the blocks before actually centering the player if you have center set to 'Incomplete', and it thinks it successfully placed all the surround blocks when it actually hasn't because it doesn't properly check the return value of the place method. That's the only bug I noticed, if I don't find any more I'll merge this after it gets fixed.

@Gingerbeard5773

Gingerbeard5773 commented Sep 25, 2025

Copy link
Copy Markdown
Contributor Author

theoretically that would mean that the bug was present before my pr, but likely wasnt noticed since the blocks got placed too slowly. fixing this rn

@Wide-Cat Wide-Cat merged commit 7581756 into MeteorDevelopment:master Sep 25, 2025
1 check passed
MukjepScarlet pushed a commit to MukjepScarlet/meteor-client that referenced this pull request Oct 7, 2025
- Added `Air Place` setting for servers that don't allow air place
- Added `Blocks per Tick` setting to allow for more blocks to be placed per tick on applicable servers
- Fix a couple of bugs
MistressOfDNS pushed a commit to MistressOfDNS/meteor-client-fork that referenced this pull request May 7, 2026
- Added `Air Place` setting for servers that don't allow air place
- Added `Blocks per Tick` setting to allow for more blocks to be placed per tick on applicable servers
- Fix a couple of bugs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

surround [Suggestion] Make surround place support blocks [Suggestion] Add Anti Airplace Surround [Suggestion] Crystal Aura Anti Surround Break

2 participants