Surround improvements#5459
Merged
Wide-Cat merged 6 commits intoSep 25, 2025
Merged
Conversation
* Added air place option for servers that don't allow air place * Added blocks per tick setting to allow for more blocks to be placed per tick.
Contributor
Author
|
Updated to 1.21.8, waiting for review |
Wide-Cat
requested changes
Sep 25, 2025
Wide-Cat
left a comment
Collaborator
There was a problem hiding this comment.
If you have a high blocks per tick value it often doesn't center the player properly, leading to your surround being half built. It seems to be because it tries to place all the blocks before actually centering the player if you have center set to 'Incomplete', and it thinks it successfully placed all the surround blocks when it actually hasn't because it doesn't properly check the return value of the place method. That's the only bug I noticed, if I don't find any more I'll merge this after it gets fixed.
Contributor
Author
|
theoretically that would mean that the bug was present before my pr, but likely wasnt noticed since the blocks got placed too slowly. fixing this rn |
MukjepScarlet
pushed a commit
to MukjepScarlet/meteor-client
that referenced
this pull request
Oct 7, 2025
- Added `Air Place` setting for servers that don't allow air place - Added `Blocks per Tick` setting to allow for more blocks to be placed per tick on applicable servers - Fix a couple of bugs
MistressOfDNS
pushed a commit
to MistressOfDNS/meteor-client-fork
that referenced
this pull request
May 7, 2026
- Added `Air Place` setting for servers that don't allow air place - Added `Blocks per Tick` setting to allow for more blocks to be placed per tick on applicable servers - Fix a couple of bugs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Air Placesetting for servers that don't allow air place.Blocks Per Ticksetting to allow for more blocks to be placed per tick, which means instant/faster placement on applicable servers.Related issues
resolves #3474, resolves #900, resolves #844, resolves #3691, partially addresses #2930
How Has This Been Tested?
Minecraft_.1.21.4.-.Singleplayer.2025-06-04.00-16-48.mp4
I also tested blocks per tick on Constantiam and was able to get 4 blocks per tick (instant placement)
Checklist: