Skip to content

auto-tool improvements, split anti-break into its own module#5708

Draft
chri-k wants to merge 5 commits into
MeteorDevelopment:masterfrom
chri-k:pr-anti-break
Draft

auto-tool improvements, split anti-break into its own module#5708
chri-k wants to merge 5 commits into
MeteorDevelopment:masterfrom
chri-k:pr-anti-break

Conversation

@chri-k

@chri-k chri-k commented Sep 20, 2025

Copy link
Copy Markdown
Contributor

Type of change

  • Bug fix
  • New feature

Description

auto-tool changes

  • setting to break glass with silk touch tools if possible
  • settings to allow using tools from the entire inventory
  • setting to try to switch to non-tool item when no tool is found

new module ToolSaver

  • replaces anti-break functionality everywhere other than AutoFish
  • setting to allow breaking tools anyway if a better one is present in inventory (very useful in conjunction with auto-tool), or breaking tools which don't have mending
  • other modules should check whether this module will allow a tool to be used before selecting it (KillAura still does not due to a few reasons)

Related issues

resolves #5707 (by accident)
resolves #1805
resolves #4785
partially resolves #2255
superset of #3992 (did not know that existed)

possibly others

How Has This Been Tested?

direct functionality and interaction with some other modules was tested, but there is probably at least one buggy edge-case somewhere

Checklist:

  • Code follows the style guidelines of this project.
  • Comments exist in more complex areas
  • Tested in both development and production environments.

@chri-k

chri-k commented Sep 20, 2025

Copy link
Copy Markdown
Contributor Author

why did the check not run (it did, but it took over a minute for it to even be queued for some reason)

@elijah-yum

Copy link
Copy Markdown

How will this affect the legacy of popbob?

@chri-k

chri-k commented Sep 21, 2025

Copy link
Copy Markdown
Contributor Author

don't spam random github comments

@chri-k chri-k marked this pull request as draft October 1, 2025 05:21
@Powie69

Powie69 commented May 11, 2026

Copy link
Copy Markdown
Contributor

Please undraft and merge 🚀🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants