auto-tool improvements, split anti-break into its own module#5708
Draft
chri-k wants to merge 5 commits into
Draft
auto-tool improvements, split anti-break into its own module#5708chri-k wants to merge 5 commits into
chri-k wants to merge 5 commits into
Conversation
Contributor
Author
|
why did the check not run (it did, but it took over a minute for it to even be queued for some reason) |
55f7808 to
2671b97
Compare
|
How will this affect the legacy of popbob? |
Contributor
Author
|
don't spam random github comments |
Contributor
|
Please undraft and merge 🚀🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
auto-tool changes
new module
ToolSaverAutoFishKillAurastill does not due to a few reasons)Related issues
resolves #5707 (by accident)
resolves #1805
resolves #4785
partially resolves #2255
superset of #3992 (did not know that existed)
possibly others
How Has This Been Tested?
direct functionality and interaction with some other modules was tested, but there is probably at least one buggy edge-case somewhere
Checklist: