implement prefer silk touch to Auto Tool#5730
Open
noramibu wants to merge 5 commits into
Open
Conversation
noramibu
changed the title
machiecodes
reviewed
Oct 1, 2025
machiecodes
reviewed
Oct 1, 2025
Contributor
Author
|
turns out fortune for ores and crops option doesn't work on crops bcs there's simply no suitable tool for it. a simple bypass would do the trick for #5243 |
Contributor
Author
|
this would do the trick |
noramibu
commented
Oct 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
removed silk touch for ender chest option and implemented a whitelist for silk touch. If a suitable tool exists and block is in whitelist, it will always prefer silk touch (unless user doesn't have a silk touch tool, in that case it will choose most suitable tool (or fortune tool if fortuneForOresCrops enabled))
also fixed fortuneForOresCrops wasn't working for crops because there was no suitable tool for it (now they simply bypass tool check if fortuneForOresCrops is on)
Related issues
#5729 #5243 #5983
How Has This Been Tested?
https://youtu.be/ECl49wCImMs
Checklist: