Replace Shadow JAR with proper JiJ implementation#5754
Merged
Conversation
Contributor
Game-provided libs should be excluded. |
Contributor
|
And |
Collaborator
Author
Good catch, I see that the older Shadow impl did exclude this. |
- `slf4j` is provided by Minecraft/Fabric - `jsr305` is used for comp-time annotations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Replace Shadow JAR with proper JiJ implementation.
This is a rewrite of the now closed #5330 PR, updated to the new 1.21.9 branch.
The implementation relies on this source for its transitive dependency handling.
Related issues
None.
How Has This Been Tested?
Tested by loading the produced JAR in a fresh Fabric instance via PrismLauncher.
Checklist: