Skip to content

fix: elytrafly bounce crash#5770

Merged
Wide-Cat merged 2 commits into
MeteorDevelopment:masterfrom
cattyngmd:fix-bounce-efly
Oct 14, 2025
Merged

fix: elytrafly bounce crash#5770
Wide-Cat merged 2 commits into
MeteorDevelopment:masterfrom
cattyngmd:fix-bounce-efly

Conversation

@cattyngmd

Copy link
Copy Markdown
Contributor

Type of change

  • Bug fix
  • New feature

Description

The PlayerEntity.startGliding method is not thread safe. It invokes ClientPlayerEntity.onTrackedDataSet that meanwhile adds a sound to sound manager queue causing ConcurrentModificationException if executed not on the main thread.

Related issues

#4389

Checklist:

  • My code follows the style guidelines of this project.
  • I have added comments to my code in more complex areas.
  • I have tested the code in both development and production environments.

@Wide-Cat

Copy link
Copy Markdown
Collaborator

Make it use the mc variable instead of MinecraftClient.getInstance and I'll merge this

@cattyngmd

cattyngmd commented Oct 14, 2025

Copy link
Copy Markdown
Contributor Author

i cant use mc constant bcs its declared as non staic in ElytraFlightMode and the ignoreGround is static method

import static is not allowed in this context bcs the `mc` field is declared in parent class : (
@Wide-Cat Wide-Cat merged commit eb166f5 into MeteorDevelopment:master Oct 14, 2025
1 check passed
@cattyngmd cattyngmd deleted the fix-bounce-efly branch October 14, 2025 21:24
chri-k added a commit to chri-k/meteor-client that referenced this pull request Nov 15, 2025
MistressOfDNS pushed a commit to MistressOfDNS/meteor-client-fork that referenced this pull request May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants