Skip to content

replace old mixin fields with @Share#5821

Merged
Wide-Cat merged 3 commits into
MeteorDevelopment:masterfrom
crosby-moe:chore/remove-residual-unique-usages
Nov 6, 2025
Merged

replace old mixin fields with @Share#5821
Wide-Cat merged 3 commits into
MeteorDevelopment:masterfrom
crosby-moe:chore/remove-residual-unique-usages

Conversation

@crosby-moe

@crosby-moe crosby-moe commented Nov 3, 2025

Copy link
Copy Markdown
Collaborator

Type of change

  • Bug fix
  • New feature
  • Chore 😔

Description

A summary of the changes along with the reasoning behind the changes.

Related issues

none

How Has This Been Tested?

the J

Checklist:

  • My code follows the style guidelines of this project.
  • I have added comments to my code in more complex areas.
  • I have tested the code in both development and production environments.

@I-No-oNe

I-No-oNe commented Nov 4, 2025

Copy link
Copy Markdown

What is the idea behind the PR?
(Does @Unique have problems, etc')

@crosby-moe

crosby-moe commented Nov 5, 2025

Copy link
Copy Markdown
Collaborator Author

What is the idea behind the PR? (Does @Unique have problems, etc')

before mixin extras was added to fabric loader with @Share and easy local usage with @Local, you would store data between injections using a field (optionally annotated with @Unique)

there is no real problem with @Unique but this practice of storing intermediate state can cause issues (#5820) and is a relic of a past without mixin extras, hence why this pr modernizes these cases

though, i suppose the name of this pull request isn't really clear..

@crosby-moe crosby-moe changed the title remove residual @Unique usages replace old mixin fields with @Share Nov 5, 2025
@Wide-Cat Wide-Cat merged commit d74597e into MeteorDevelopment:master Nov 6, 2025
1 check passed
MistressOfDNS pushed a commit to MistressOfDNS/meteor-client-fork that referenced this pull request May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants