Skip to content

Fix strange conditional in BookBot.java#5835

Merged
MineGame159 merged 1 commit into
MeteorDevelopment:masterfrom
VallionXD:master
Nov 7, 2025
Merged

Fix strange conditional in BookBot.java#5835
MineGame159 merged 1 commit into
MeteorDevelopment:masterfrom
VallionXD:master

Conversation

@VallionXD

Copy link
Copy Markdown
Contributor

Type of change

  • Bug fix
  • New feature

Description

A summary of the changes along with the reasoning behind the changes.

Fixed a null pointer access warning by changing the condition from

(component != null || component.pages().isEmpty())

to

(component == null || component.pages().isEmpty())

If you didn't see the difference, changed to != from ==.

Related issues

None as far as I am aware.

How Has This Been Tested?

Videos or screenshots of the changes if applicable.

A patch this small doesn't require testing.. just look at the change.

Checklist:

  • My code follows the style guidelines of this project.
  • I have added comments to my code in more complex areas.
  • I have tested the code in both development and production environments.

@VallionXD VallionXD changed the title Fix strange conditional Fix strange conditional in BookBot.java Nov 7, 2025
@crosby-moe

Copy link
Copy Markdown
Collaborator

can confirm, bookbot crashes with /give @s writable_book[!minecraft:writable_book_content]

@MineGame159 MineGame159 merged commit 7686636 into MeteorDevelopment:master Nov 7, 2025
1 check passed
MistressOfDNS pushed a commit to MistressOfDNS/meteor-client-fork that referenced this pull request May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants