Skip to content

Translations, but better#5862

Merged
Wide-Cat merged 14 commits into
MeteorDevelopment:translationsfrom
crosby-moe:translations-but-better
Jan 2, 2026
Merged

Translations, but better#5862
Wide-Cat merged 14 commits into
MeteorDevelopment:translationsfrom
crosby-moe:translations-but-better

Conversation

@crosby-moe

Copy link
Copy Markdown
Collaborator

Type of change

  • Bug fix
  • New feature

Description

  • improved exception logging
  • greatly lowered translation overhead
  • force utf 8
  • encode rtl field in MeteorLanguage, (still unused)
  • enforce case sensitivity
  • replace MeteorAddon#provideLanguage with automatic registration, following fabric-resource-loader-v0's functionality
  • added MeteorAddon#id
  • fixes in CommandsCommand and meteor.command.wasp.info.target

How Has This Been Tested?

The J

Checklist:

  • My code follows the style guidelines of this project.
  • I have added comments to my code in more complex areas.
  • I have tested the code in both development and production environments.

@NikOverflow

Copy link
Copy Markdown

I have the feeling that this will still take some time. Maybe you should still add ExploitPreventer. Liquid Bounce will also start using it: CCBlueX/LiquidBounce#7397

There are no disadvantages in using it.

@1zun4

1zun4 commented Dec 17, 2025

Copy link
Copy Markdown

I have the feeling that this will still take some time. Maybe you should still add ExploitPreventer. Liquid Bounce will also start using it: CCBlueX/LiquidBounce#7397

There are no disadvantages in using it.

We use our own translation system similar to this PR, which makes it irrelevant whether we prevent translation key detection or not. This does not affect how the game works, while keeping Meteor safe from detection.

Also, sometimes you want the server to know that a mod is present, but you clearly don't want it to know that you have a hacked client installed. This is not yet possible to configure using Exploit Preventer.

@NikOverflow

Copy link
Copy Markdown

I have the feeling that this will still take some time. Maybe you should still add ExploitPreventer. Liquid Bounce will also start using it: CCBlueX/LiquidBounce#7397
There are no disadvantages in using it.

We use our own translation system similar to this PR, which makes it irrelevant whether we prevent translation key detection or not. This does not affect how the game works, while keeping Meteor safe from detection.

Also, sometimes you want the server to know that a mod is present, but you clearly don't want it to know that you have a hacked client installed. This is not yet possible to configure using Exploit Preventer.

yes I know that you have your own translation system. I will add a way for configuring the mods but it will take some time.

@crosby-moe crosby-moe changed the base branch from master to translations January 2, 2026 00:40
@Wide-Cat Wide-Cat merged commit ad3c0b3 into MeteorDevelopment:translations Jan 2, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants