Skip to content

Commit ca4bb01

Browse files
sevaaSeva AlekseyevSebastianSchuetze
authored
fix: URLEncoding of query string parameters (#523)
Refactor to get rid of crude and incorrect _appendQueryString. Query string parameter values that can potentially be strings should be URLEncoded. Also, _appendQueryString was assuming that the URL already had a query string and produced invalid URLs if the API version was blank. Fixes #442, #517 --------- Co-authored-by: Seva Alekseyev <sevaa@nih.gov> Co-authored-by: Sebastian Schütze <sebastian.schuetze@razorspoint.com>
1 parent ec50dc9 commit ca4bb01

15 files changed

Lines changed: 222 additions & 148 deletions

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,9 @@ Merged [Pull Request](https://github.com/MethodsAndPractices/vsteam/pull/515) fr
88
Merged [Pull Request](https://github.com/MethodsAndPractices/vsteam/pull/508) from [Miguel Nieto](https://github.com/mnieto) the following:
99
- Fix import-module loses previously stored configuration [493](https://github.com/MethodsAndPractices/vsteam/issues/493)
1010

11+
Merged [Pull Request](https://github.com/MethodsAndPractices/vsteam/pull/523) from [Seva Alekseyev](https://github.com/sevaa) the following:
12+
- Fix import-module loses previously stored configuration [442](https://github.com/MethodsAndPractices/vsteam/issues/442)[517](https://github.com/MethodsAndPractices/vsteam/issues/517)
13+
1114
## 7.12.0
1215

1316

0 commit comments

Comments
 (0)