feat: bundled installers for all, source installers for v2 (#21)

* bundled installers for all, source installers for v2
* performance improvements (stolen from asdf-vm/asdf-plugin-template#58)
* update readme,contributing,funding
* workflows: move schedules from daily to weekly, just build on earliest/latest python supported

Author: MetricMike

.github/FUNDING.yml

@@ -0,0 +1 @@
+github: [MetricMike]

.github/dependabot.yml

@@ -0,0 +1,7 @@
+# .github/dependabot.yml
+version: 2
+updates:
+  - package-ecosystem: "github-actions"
+    directory: "/"
+    schedule:
+      interval: "weekly" # Check for updates to GitHub Actions every week

.github/workflows/build.yml

@@ -1,8 +1,7 @@
 name: Build
+
 on:
   pull_request:
-    branches:
-      - main
     paths-ignore:
       - "**.md"
   push:
@@ -11,24 +10,70 @@ on:
     paths-ignore:
       - "**.md"
   schedule:
-    - cron: "0 0 * * *" # daily at midnight
+    - cron: "0 0 * * 0" # weekly at midnight on sundays (ish)
+
+env:
+  ASDF_CONCURRENCY: 2
 
 jobs:
-  plugin_test:
-    name: asdf plugin test
+  build_from_installers:
+    name: asdf-awscli plugin test using prebuilt installers
     strategy:
       matrix:
-        os: [ubuntu-latest, macos-latest]
-        python-version: ['3.7', '3.8', '3.9', '3.10']
-        cli-version: ['latest:1', 'latest:2']
+        os:
+          - ubuntu-latest
+          - macos-latest
+          # - windows-latest In theory this should work, but ASDF requires bash and
+        python-version:
+          - "3.8"
+          - "3.11"
+        cli-version:
+          - "latest:1"
+          - "latest:2"
     runs-on: ${{ matrix.os }}
     steps:
       - name: Set up Python
         uses: actions/setup-python@v4
         with:
           python-version: ${{ matrix.python-version }}
+
       - name: asdf_plugin_test
-        uses: asdf-vm/actions/plugin-test@v1
+        uses: asdf-vm/actions/plugin-test@v2
         with:
           command: aws --version
           version: ${{ matrix.cli-version }}
+
+  build_from_source:
+    name: asdf-awscli plugin test using source
+    strategy:
+      matrix:
+        os:
+          - ubuntu-latest
+          - macos-latest
+        python-version:
+          - "3.8"
+          - "3.11"
+    runs-on: ${{ matrix.os }}
+    steps:
+      - name: Set up Python
+        uses: actions/setup-python@v4
+        with:
+          python-version: ${{ matrix.python-version }}
+
+      - name: Install asdf-awscli
+        uses: asdf-vm/actions/plugins-add@v2
+        with:
+          tool_versions: |
+            # tools won't be installed by this action, only plugins
+            awscli
+
+      - name: Retrieve latest version
+        run: |
+          echo "cli-version=ref:$(asdf latest awscli 2)" >> "${GITHUB_ENV}"
+
+      - name: asdf_plugin_test
+        uses: asdf-vm/actions/plugin-test@v2
+        with:
+          skip_install: true
+          command: aws --version
+          version: ${{ env.cli-version }}

.github/workflows/lint.yml

@@ -1,8 +1,7 @@
 name: Lint
+
 on:
   pull_request:
-    branches:
-      - main
     paths-ignore:
       - "**.md"
   push:
@@ -11,34 +10,21 @@ on:
     paths-ignore:
       - "**.md"
   schedule:
-    - cron: "0 0 * * *" # daily at midnight
+    - cron: "0 0 * * 0" # weekly at midnight on sundays (ish)
 
 jobs:
-  shellcheck:
-    name: shellcheck
+  lint:
     runs-on: ubuntu-latest
     steps:
-      - name: Checkout code
-        uses: actions/checkout@v2
-      - name: Update Shellcheck
-        run: |
-          sudo apt install xz-utils
-          scversion="stable"
-          wget -qO- "https://github.com/koalaman/shellcheck/releases/download/${scversion?}/shellcheck-${scversion?}.linux.x86_64.tar.xz" | tar -xJv
-          sudo cp "shellcheck-${scversion}/shellcheck" /usr/bin/
-          shellcheck --version
-      - name: Shellcheck
-        run: shellcheck -x bin/* -P lib/
-
-  shfmt:
-    runs-on: macos-latest
+      - uses: actions/checkout@v3
+      - uses: asdf-vm/actions/install@v2
+      - run: scripts/lint.bash
 
+  actionlint:
+    runs-on: ubuntu-latest
     steps:
-      - name: Checkout code
-        uses: actions/checkout@v2
-
-      - name: Install shfmt
-        run: brew install shfmt
-
-      - name: Run shfmt
-        run: shfmt -d -i 2 -ci .
+      - uses: actions/checkout@v3
+      - name: Check workflow files
+        uses: docker://rhysd/actionlint:1.6.23
+        with:
+          args: -color

.github/workflows/release.yml

@@ -0,0 +1,18 @@
+name: Release
+
+on:
+  push:
+    branches:
+      - main
+
+permissions:
+  contents: write
+  pull-requests: write
+
+jobs:
+  release-please:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: GoogleCloudPlatform/release-please-action@v3
+        with:
+          release-type: simple

.github/workflows/semantic-pr.yml

@@ -0,0 +1,18 @@
+name: SemanticPR
+
+on:
+  pull_request_target:
+    types:
+      - opened
+      - edited
+      - synchronize
+
+jobs:
+  semantic-pr:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: amannn/action-semantic-pull-request@v5.2.0
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        with:
+          validateSingleCommit: true

.tool-versions

@@ -0,0 +1,2 @@
+shellcheck 0.9.0
+shfmt 3.6.0

LICENSE

@@ -1,6 +1,6 @@
 MIT License
 
-Copyright (c) 2021 Michael Weigle
+Copyright (c) 2023 Michael Weigle
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

README.md

@@ -6,6 +6,9 @@
 
 </div>
 
+# Build History
+[![Build history](https://buildstats.info/github/chart/MetricMike/asdf-awscli?branch=main)](https://github.com/MetricMike/asdf-awscli/actions)
+
 # Contents
 
 - [Dependencies](#dependencies)
@@ -16,10 +19,10 @@
 # Dependencies
 
 - `curl`, `git`: Required by [asdf](https://asdf-vm.com/guide/getting-started.html#_1-install-dependencies)
-- `bash`, `tar`, `unzip`: generic POSIX utilities. These should be installed by default on most operating systems.
-
-- v1 - Linux/MacOS/Windows || v2 - Windows
-  - `Python 3+ w/ current support (3.7.13+ as of 20JUN2022)`: For v1 (and v2 on Windows until https://github.com/MetricMike/asdf-awscli/issues/2 is resolved), this plugin installs awscli from source into a virtualenv on these OS distributions utilizing pip. In theory, most Python 3s will be sufficient, but issues will be closed if the Python is not listed as green on https://endoflife.date/python.
+- `bash`, `tar`, `unzip`, `coreutils`: generic POSIX utilities. These should be installed by default on most operating systems.
+- Python 3.8+ (v1, v2 when building from source) https://aws.amazon.com/blogs/developer/python-support-policy-updates-for-aws-sdks-and-tools/
+- `make/autotools` (v2 when building from source)
+- `Rosetta 2` (v2 when using the pre-built installers on Apple Silicon)
 
 # Install
 
@@ -37,18 +40,48 @@ awscli:
 # Show all installable versions
 asdf list all awscli
 
-# Install specific version
-asdf install awscli latest   # 2.1.24
-asdf install awscli latest:2 # 2.1.24
-asdf install awscli latest:1 # 1.19.4
+# Install the latest version (optionally with a version prefix)
+asdf install awscli latest   # 2.11.15
+asdf install awscli latest:2 # 2.11.15
+asdf install awscli latest:1 # 1.27.119
+
+# Install a specific version
+asdf install awscli 2.11.15
+asdf install awscli 1.27.119
+
+# Build and install v2 from from source
+asdf install awscli ref:2.11.15
+asdf install awscli "ref:$(asdf latest awscli 2)" # 2.11.15
 
 # Set a version globally (on your ~/.tool-versions file)
 asdf global awscli latest
 
 # Now awscli commands are available
-aws --help
+aws --version
 ```
 
+### v1 - Linux/MacOS/Windows
+
+Only the pre-built installer is supported by this plugin for AWS CLI v1. If you need to build from source, install via `pip`.
+
+Note: The pre-built installers require a Python 3.8+ distribution at install-time **and this Python must remain installed** as they're just creating an isolated virtualenv and copying their site-packages over. Refer to the [AWS CLI v1 Python version support matrix](https://docs.aws.amazon.com/cli/v1/userguide/cli-chap-install.html#cli-chap-install-python) for which Pythons support which AWS CLI versions. If you remove the Python distribution used at install-time, **you must reinstall AWS CLI**.
+
+### v2 - [Pre-built Installers](https://docs.aws.amazon.com/cli/latest/userguide/getting-started-version.html)
+
+The macOS flavor only provides an x86_64 binary. You *must* install Rosetta 2 if using Apple Silicon (M1/M2/arm64).
+
+The Linux flavor provides both x86_64 and aarch64 binaries, but has dependencies on glibc, groff, and less. Alpine/musl users should build from source.
+
+The Windows flavor technically works, but ASDF's support for Windows isn't 100% yet.
+
+### v2 - [Build and install from source](https://docs.aws.amazon.com/cli/latest/userguide/getting-started-source-install.html)
+
+This is only supported starting from [v2.10.0 / 2023-02-15](https://github.com/aws/aws-cli/pull/7668)
+
+Building and installing from source requires a Python 3.8+ distribution at build-time. This plugin uses the `--with-install-type=portable-exe` and `--with-download-deps` flags to download all required Python dependencies and freeze a static copy of the build-time Python distribution. After a successful installation, there are no dependencies to your build time environment, and the ASDF installs folder could be shared with another air-gapped system that did not have a Python installation.
+
+---
+
 Check [asdf](https://github.com/asdf-vm/asdf) readme for more instructions on how to
 install & manage versions.
 

bin/download

@@ -0,0 +1,76 @@
+#!/usr/bin/env bash
+
+set -euo pipefail
+
+current_script_path=${BASH_SOURCE[0]}
+plugin_dir=$(dirname "$(dirname "${current_script_path}")")
+
+# shellcheck source=../lib/utils.bash
+. "${plugin_dir}/lib/utils.bash"
+
+TOOL_NAME="awscli"
+CURL_OPTS=(-fsSL)
+
+mkdir -p "${ASDF_DOWNLOAD_PATH}"
+
+download_source() {
+	local version download_path major_version
+	version="$1"
+	download_path="$2"
+	major_version="${version:0:1}"
+
+	if [[ "${major_version}" = "2" ]]; then
+		source_url="https://awscli.amazonaws.com/awscli-${version}.tar.gz"
+		filename="awscli.tar.gz"
+		source_file="${download_path}/${filename}"
+		curl "${CURL_OPTS[@]}" -o "${source_file}" -C - "${source_url}" || fail "Could not download ${source_url}"
+		tar -xzf "${source_file}" -C "${download_path}" --strip-components=1 || fail "Could not extract ${source_file}"
+		rm "${source_file}"
+	else
+		fail "asdf-${TOOL_NAME} does not support downloading from source for major version v${major_version}"
+	fi
+}
+
+download_release() {
+	local version download_path major_version
+	version="$1"
+	download_path="$2"
+	major_version="${version:0:1}"
+
+	if [[ "${major_version}" = "1" ]]; then
+		release_url="https://s3.amazonaws.com/aws-cli/awscli-bundle-${version}.zip"
+		filename="awscli-bundle.zip"
+	elif [[ "${major_version}" = "2" ]]; then
+		if [[ "${OS_NAME}" = "Linux" ]]; then
+			if [[ "${OS_ARCH}" = "x86_64" || "${OS_ARCH}" = "aarch64" ]]; then
+				release_url="https://awscli.amazonaws.com/awscli-exe-linux-${OS_ARCH}-${version}.zip"
+				filename="awscliv2.zip"
+			else
+				fail "asdf-${TOOL_NAME} does not support ${OS_ARCH} on ${OS_NAME}"
+			fi
+		elif [[ "${OS_NAME}" = "Darwin" ]]; then
+			release_url="https://awscli.amazonaws.com/AWSCLIV2-${version}.pkg"
+			filename="AWSCLIV2.pkg"
+		elif [[ "${OS_NAME}" = "Windows_NT" ]]; then
+			release_url="https://awscli.amazonaws.com/AWSCLIV2-${version}.msi"
+			filename="AWSCLIV2.msi"
+		else
+			fail "asdf-${TOOL_NAME} does not support OS distribution ${OS_NAME}"
+		fi
+	else
+		fail "asdf-${TOOL_NAME} does not support major version v${version}"
+	fi
+
+	release_file="${download_path}/${filename}"
+	curl "${CURL_OPTS[@]}" -o "${release_file}" "${release_url}" || fail "Could not download ${release_url}"
+	if [[ "${release_file: -3}" = "zip" ]]; then
+		unzip -oq "${release_file}" -d "${download_path}"
+		rm "${release_file}"
+	fi
+}
+
+if [ "${ASDF_INSTALL_TYPE}" = "version" ]; then
+	download_release "${ASDF_INSTALL_VERSION}" "${ASDF_DOWNLOAD_PATH}"
+elif [ "${ASDF_INSTALL_TYPE}" = "ref" ]; then
+	download_source "${ASDF_INSTALL_VERSION}" "${ASDF_DOWNLOAD_PATH}"
+fi