Fix crashes in NovelInfoActivity due to lifecycle issues#173
Conversation
… dismissed dialogs Refactored `NovelInfoActivity` to extract UI update logic from `onResume` into `updateUI`. Updated `AsyncUpdateCacheTask`, `AsyncDownloadVolumes`, and `AsyncRemoveBookFromCloud` `onPostExecute` methods to use `updateUI` instead of manually calling `onResume`. Added checks for `isFinishing()` and `isDestroyed()` to prevent UI updates on a destroyed activity. Guarded dialog dismissal with try-catch blocks to handle `IllegalArgumentException`. Co-authored-by: MewX <5752560+MewX@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This PR fixes three distinct crashes in
NovelInfoActivity:IllegalStateException: FragmentManager has been destroyed: Caused by manually callingonResume()fromonPostExecute. Replaced with a newupdateUI()method.IllegalArgumentExceptioninWindowManagerGlobal.findViewLocked: Caused by dismissing dialogs after the activity is destroyed. Added checks forisFinishing()andisDestroyed()and wrappeddismiss()calls in try-catch blocks.IllegalArgumentExceptioninAsyncRemoveBookFromCloud.Testing:
./gradlew assembleAlphaDebug.PR created automatically by Jules for task 8659018325587298001 started by @MewX