RHINENG-21214: remove unused insights_id

Author: MichaelMraka

docs/v3/openapi.json

@@ -2446,14 +2446,6 @@
                             "type": "string"
                         }
                     },
-                    {
-                        "name": "filter[insights_id]",
-                        "in": "query",
-                        "description": "Filter",
-                        "schema": {
-                            "type": "string"
-                        }
-                    },
                     {
                         "name": "filter[display_name]",
                         "in": "query",
@@ -7182,9 +7174,6 @@
                             "$ref": "#/components/schemas/controllers.SystemGroup"
                         }
                     },
-                    "insights_id": {
-                        "type": "string"
-                    },
                     "installable_other_count": {
                         "type": "integer"
                     },

manager/controllers/advisory_systems.go

@@ -218,7 +218,6 @@ func systemsIDsStatus(c *gin.Context, systems []SystemsStatusID, meta *ListMeta)
 // @Param    sort    query   string  false   "Sort field" Enums(id,display_name,last_evaluation,last_upload,rhsa_count,rhba_count,rhea_count,other_count,satellite_managed,stale,built_pkgcache)
 // @Param    search         query   string  false   "Find matching text"
 // @Param    filter[id]              query   string  false "Filter"
-// @Param    filter[insights_id]     query   string  false "Filter"
 // @Param    filter[display_name]    query   string  false "Filter"
 // @Param    filter[last_evaluation] query   string  false "Filter"
 // @Param    filter[last_upload]     query   string  false "Filter"

manager/controllers/systems.go

@@ -101,9 +101,8 @@ type SystemItemAttributes struct {
 // nolint: lll
 type SystemItemAttributesExtended struct {
 	SystemItemAttributes
-	ThirdParty        bool   `json:"third_party" csv:"third_party" query:"sp.third_party" gorm:"column:third_party"`
-	InsightsID        string `json:"insights_id" csv:"insights_id" query:"ih.insights_id" gorm:"column:insights_id"`
-	PackagesUpdatable int    `json:"packages_updatable" csv:"packages_updatable" query:"sp.packages_installable" gorm:"column:packages_updatable"`
+	ThirdParty        bool `json:"third_party" csv:"third_party" query:"sp.third_party" gorm:"column:third_party"`
+	PackagesUpdatable int  `json:"packages_updatable" csv:"packages_updatable" query:"sp.packages_installable" gorm:"column:packages_updatable"`
 
 	OSName  string `json:"os_name" csv:"os_name" query:"ih.system_profile->'operating_system'->>'name'" gorm:"column:osname"`
 	OSMajor string `json:"os_major" csv:"os_major" query:"ih.system_profile->'operating_system'->>'major'" gorm:"column:osmajor"`