Skip to content

Commit 08df10b

Browse files
committed
RHINENG-21447: create metrics to track usage of *_account_data
1 parent 73960ce commit 08df10b

3 files changed

Lines changed: 18 additions & 0 deletions

File tree

manager/controllers/advisories.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,8 +92,10 @@ func advisoriesCommon(c *gin.Context) (*gorm.DB, *ListMeta, []string, error) {
9292
}
9393

9494
if config.DisableCachedCounts || HasInventoryFilter(filters) || len(groups) != 0 {
95+
middlewares.AdvisoryAccountDataHitsCnt.WithLabelValues("hit").Inc()
9596
query = buildQueryAdvisoriesTagged(db, filters, account, groups)
9697
} else {
98+
middlewares.AdvisoryAccountDataHitsCnt.WithLabelValues("miss").Inc()
9799
query = buildQueryAdvisories(db, account)
98100
}
99101

manager/controllers/packages.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,12 +57,14 @@ var queryItemSelect = database.MustGetSelect(&queryItem{})
5757
func packagesQuery(db *gorm.DB, filters map[string]FilterData, acc int, groups map[string]string,
5858
useCache bool) *gorm.DB {
5959
if useCache {
60+
middlewares.PackageAccountDataHitsCnt.WithLabelValues("hit").Inc()
6061
q := db.Table("package_account_data res").
6162
Select(PackagesSelect).
6263
Joins("JOIN package_name pn ON res.package_name_id = pn.id").
6364
Where("rh_account_id = ?", acc)
6465
return q
6566
}
67+
middlewares.PackageAccountDataHitsCnt.WithLabelValues("miss").Inc()
6668
systemsWithPkgsInstalledQ := database.Systems(db, acc, groups).
6769
Select("sp.id").
6870
Where("sp.stale = false AND sp.packages_installed > 0")

manager/middlewares/prometheus.go

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,20 @@ var AdvisoryDetailGauge = prometheus.NewGauge(prometheus.GaugeOpts{
4343
Name: "advisory_detail_cache_size",
4444
})
4545

46+
var AdvisoryAccountDataHitsCnt = prometheus.NewCounterVec(prometheus.CounterOpts{
47+
Help: "How many requests hit/miss advisory_account_data",
48+
Namespace: "patchman_engine",
49+
Subsystem: "manager",
50+
Name: "advisory_account_data_hits",
51+
}, []string{"type"})
52+
53+
var PackageAccountDataHitsCnt = prometheus.NewCounterVec(prometheus.CounterOpts{
54+
Help: "How many requests hit/miss package_account_data",
55+
Namespace: "patchman_engine",
56+
Subsystem: "manager",
57+
Name: "package_account_data_hits",
58+
}, []string{"type"})
59+
4660
// Create and configure Prometheus middleware to expose metrics
4761
func Prometheus() *ginprometheus.Prometheus {
4862
prometheus.MustRegister(serviceErrorCnt, requestDurations, callerSourceCnt,

0 commit comments

Comments
 (0)