RHINENG-21424: handle null/notnull filters

Author: MichaelMraka

manager/controllers/filter.go

@@ -79,7 +79,7 @@ func checkValueCount(operator string, nValues int) bool {
 // Convert a single filter to where clauses
 func (t *FilterData) ToWhere(fieldName string, attributes database.AttrMap) (string, []any, error) {
 	var err error
-	transformedValues, transformedOperator := transformFilterParams(fieldName, t.Values, t.Operator)
+	transformedOperator, transformedValues := t.transformParams(fieldName)
 	var values = make([]interface{}, len(transformedValues))
 	for i, v := range transformedValues {
 		fieldInfo, found := attributes[fieldName]
@@ -127,35 +127,43 @@ func (t *FilterData) ToWhere(fieldName string, attributes database.AttrMap) (str
 	}
 }
 
-// transformFilterParams Allow exceptions in ToWhere values usage (e.g. "other").
-func transformFilterParams(fieldName string, originalValues []string, originalOperator string) (
-	transformedValues []string, transformedOperator string) {
-	if fieldName != "advisory_type_name" {
-		return originalValues, originalOperator
+func (t *FilterData) transformParams(fieldName string) (operator string, values []string) {
+	if len(t.Values) == 1 && (t.Values[0] == "null" || t.Values[0] == "notnull") {
+		// handle special cases filter=null and filter=notnull
+		return t.Values[0], []string{"0"}
 	}
+	if fieldName == "advisory_type_name" {
+		return t.transformAdvisoryTypeParams()
+	}
+	// no change
+	return t.Operator, t.Values
+}
 
-	transformedValues = make([]string, 0, len(originalValues))
-	for _, originalValue := range originalValues {
+func (t *FilterData) transformAdvisoryTypeParams() (
+	// expand "other" in advisory_type filter into list of what we mean by other
+	transformedOperator string, transformedValues []string) {
+	transformedValues = make([]string, 0, len(t.Values))
+	for _, originalValue := range t.Values {
 		if originalValue == "other" {
 			transformedValues = append(transformedValues, database.OtherAdvisoryTypes...)
 		} else {
 			transformedValues = append(transformedValues, originalValue)
 		}
 	}
 
-	if len(transformedValues) == len(originalValues) {
-		return originalValues, originalOperator
+	if len(transformedValues) == len(t.Values) {
+		return t.Operator, t.Values
 	}
 
-	switch originalOperator {
+	switch t.Operator {
 	case OpEq:
 		transformedOperator = OpIn
 	case OpNeq:
 		transformedOperator = OpNotIn
 	default:
-		transformedOperator = originalOperator
+		transformedOperator = t.Operator
 	}
-	return transformedValues, transformedOperator
+	return transformedOperator, transformedValues
 }
 
 func (t Filters) ToQueryParams() string {