Skip to content

Commit 883414e

Browse files
committed
put both advisory cache metrics into a single graph
1 parent a0c0841 commit 883414e

1 file changed

Lines changed: 37 additions & 8 deletions

File tree

dashboards/app-sre/grafana-dashboard-insights-patchman-engine-general.configmap.yaml

Lines changed: 37 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2443,7 +2443,7 @@ data:
24432443
"axisBorderShow": false,
24442444
"axisCenteredZero": false,
24452445
"axisColorMode": "text",
2446-
"axisLabel": "Hit ratio",
2446+
"axisLabel": "Items",
24472447
"axisPlacement": "auto",
24482448
"barAlignment": 0,
24492449
"barWidthFactor": 0.6,
@@ -2478,9 +2478,7 @@ data:
24782478
"mappings": [
24792479
24802480
],
2481-
"max": 1,
24822481
"min": 0,
2483-
"noValue": "0%",
24842482
"thresholds": {
24852483
"mode": "absolute",
24862484
"steps": [
@@ -2493,10 +2491,29 @@ data:
24932491
}
24942492
]
24952493
},
2496-
"unit": "percentunit"
2494+
"unit": "none"
24972495
},
24982496
"overrides": [
2499-
2497+
{
2498+
"matcher": {
2499+
"id": "byName",
2500+
"options": "hit ratio"
2501+
},
2502+
"properties": [
2503+
{
2504+
"id": "custom.axisLabel",
2505+
"value": "Hit ratio"
2506+
},
2507+
{
2508+
"id": "unit",
2509+
"value": "percentunit"
2510+
},
2511+
{
2512+
"id": "custom.axisPlacement",
2513+
"value": "right"
2514+
}
2515+
]
2516+
}
25002517
]
25012518
},
25022519
"gridPos": {
@@ -2513,7 +2530,7 @@ data:
25132530
],
25142531
"displayMode": "list",
25152532
"placement": "bottom",
2516-
"showLegend": false
2533+
"showLegend": true
25172534
},
25182535
"tooltip": {
25192536
"hideZeros": false,
@@ -2531,12 +2548,24 @@ data:
25312548
"editorMode": "code",
25322549
"expr": "sum(patchman_engine_manager_advisory_detail_cache{type=\"hit\"})/sum(patchman_engine_manager_advisory_detail_cache)",
25332550
"hide": false,
2534-
"legendFormat": "__auto",
2551+
"legendFormat": "hit ratio",
25352552
"range": true,
25362553
"refId": "A"
2554+
},
2555+
{
2556+
"datasource": {
2557+
"type": "prometheus",
2558+
"uid": "$datasource"
2559+
},
2560+
"editorMode": "code",
2561+
"expr": "sum(patchman_engine_manager_advisory_detail_cache_size)",
2562+
"hide": false,
2563+
"legendFormat": "size",
2564+
"range": true,
2565+
"refId": "B"
25372566
}
25382567
],
2539-
"title": "Advisory detail cache hit ratio",
2568+
"title": "Advisory detail cache",
25402569
"type": "timeseries"
25412570
},
25422571
{

0 commit comments

Comments
 (0)