RHINENG-21786: update test to JSONSlice datatype

Author: MichaelMraka

manager/controllers/advisory_detail_test.go

@@ -9,6 +9,7 @@ import (
 
 	log "github.com/sirupsen/logrus"
 	"github.com/stretchr/testify/assert"
+	"gorm.io/datatypes"
 )
 
 func TestAdvisoryDetailDefault(t *testing.T) {
@@ -32,11 +33,11 @@ func (r *AdvisoryDetailResponse) checkRH9Fields(t *testing.T) {
 	assert.Equal(t, "2018-09-22 20:00:00 +0000 UTC", r.Data.Attributes.ModifiedDate.String())
 	assert.Equal(t, 2, len(r.Data.Attributes.Packages))
 	assert.Equal(
-		t, packages{"firefox-77.0.1-1.fc31.x86_64", "firefox-77.0.1-1.fc31.s390"},
+		t, datatypes.JSONSlice[string]{"firefox-77.0.1-1.fc31.x86_64", "firefox-77.0.1-1.fc31.s390"},
 		r.Data.Attributes.Packages,
 	)
 	assert.Equal(t, false, r.Data.Attributes.RebootRequired)
-	assert.Equal(t, []string{"8.2", "8.4"}, r.Data.Attributes.ReleaseVersions)
+	assert.Equal(t, datatypes.JSONSlice[string]{"8.2", "8.4"}, r.Data.Attributes.ReleaseVersions)
 	assert.Nil(t, r.Data.Attributes.Severity)
 }
 

tasks/vmaas_sync/advisory_sync_test.go

@@ -12,6 +12,7 @@ import (
 
 	"github.com/bytedance/sonic"
 	"github.com/stretchr/testify/assert"
+	"gorm.io/datatypes"
 )
 
 func TestInit(_ *testing.T) {
@@ -97,21 +98,21 @@ func TestParseAdvisories(t *testing.T) {
 		"ER1": {
 			Updated:           "2004-09-02T00:00:00+00:00",
 			Severity:          "",
-			ReferenceList:     &[]string{},
+			ReferenceList:     []string{},
 			Issued:            "2004-09-02T00:00:00+00:00",
 			Description:       "DESC",
 			Solution:          utils.PtrString("SOL"),
 			Summary:           "SUM",
 			URL:               utils.PtrString("URL"),
 			Synopsis:          "SYN",
-			CveList:           utils.PtrSliceString([]string{"CVE-1", "CVE-2", "CVE-3"}),
-			BugzillaList:      &[]string{},
+			CveList:           []string{"CVE-1", "CVE-2", "CVE-3"},
+			BugzillaList:      []string{},
 			PackageList:       []string{},
-			SourcePackageList: &[]string{},
+			SourcePackageList: []string{},
 			Type:              "bugfix",
 			ThirdParty:        new(bool),
 			RequiresReboot:    true,
-			ReleaseVersions:   utils.PtrSliceString([]string{"8.0", "8.1"}),
+			ReleaseVersions:   []string{"8.0", "8.1"},
 		},
 	}
 
@@ -132,8 +133,8 @@ func TestParseAdvisories(t *testing.T) {
 	assert.Equal(t, 2, adv.AdvisoryTypeID)
 	assert.Equal(t, 2, adv.AdvisoryTypeID)
 	assert.Equal(t, true, adv.RebootRequired)
-	assert.Equal(t, `["CVE-1","CVE-2","CVE-3"]`, string(adv.CveList))
-	assert.Equal(t, `["8.0","8.1"]`, string(adv.ReleaseVersions))
+	assert.Equal(t, datatypes.JSONSlice[string]{"CVE-1", "CVE-2", "CVE-3"}, adv.CveList)
+	assert.Equal(t, datatypes.JSONSlice[string]{"8.0", "8.1"}, adv.ReleaseVersions)
 }
 
 func TestSaveAdvisories(t *testing.T) {