Skip to content

Commit f934e2d

Browse files
committed
put both advisory cache metrics into a single graph
1 parent 4914876 commit f934e2d

1 file changed

Lines changed: 37 additions & 7 deletions

File tree

dashboards/app-sre/grafana-dashboard-insights-patchman-engine-general.configmap.yaml

Lines changed: 37 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2443,7 +2443,7 @@ data:
24432443
"axisBorderShow": false,
24442444
"axisCenteredZero": false,
24452445
"axisColorMode": "text",
2446-
"axisLabel": "Hit ratio",
2446+
"axisLabel": "Items",
24472447
"axisPlacement": "auto",
24482448
"barAlignment": 0,
24492449
"barWidthFactor": 0.6,
@@ -2478,7 +2478,6 @@ data:
24782478
"mappings": [
24792479
24802480
],
2481-
"max": 1,
24822481
"min": 0,
24832482
"noValue": "0%",
24842483
"thresholds": {
@@ -2493,10 +2492,29 @@ data:
24932492
}
24942493
]
24952494
},
2496-
"unit": "percentunit"
2495+
"unit": "none"
24972496
},
24982497
"overrides": [
2499-
2498+
{
2499+
"matcher": {
2500+
"id": "byName",
2501+
"options": "hit ratio"
2502+
},
2503+
"properties": [
2504+
{
2505+
"id": "custom.axisLabel",
2506+
"value": "Hit ratio"
2507+
},
2508+
{
2509+
"id": "unit",
2510+
"value": "percentunit"
2511+
},
2512+
{
2513+
"id": "custom.axisPlacement",
2514+
"value": "right"
2515+
}
2516+
]
2517+
}
25002518
]
25012519
},
25022520
"gridPos": {
@@ -2513,7 +2531,7 @@ data:
25132531
],
25142532
"displayMode": "list",
25152533
"placement": "bottom",
2516-
"showLegend": false
2534+
"showLegend": true
25172535
},
25182536
"tooltip": {
25192537
"hideZeros": false,
@@ -2531,12 +2549,24 @@ data:
25312549
"editorMode": "code",
25322550
"expr": "sum(patchman_engine_manager_advisory_detail_cache{type=\"hit\"})/sum(patchman_engine_manager_advisory_detail_cache)",
25332551
"hide": false,
2534-
"legendFormat": "__auto",
2552+
"legendFormat": "hit ratio",
25352553
"range": true,
25362554
"refId": "A"
2555+
},
2556+
{
2557+
"datasource": {
2558+
"type": "prometheus",
2559+
"uid": "$datasource"
2560+
},
2561+
"editorMode": "code",
2562+
"expr": "sum(patchman_engine_manager_advisory_detail_cache_size)",
2563+
"hide": false,
2564+
"legendFormat": "size",
2565+
"range": true,
2566+
"refId": "B"
25372567
}
25382568
],
2539-
"title": "Advisory detail cache hit ratio",
2569+
"title": "Advisory detail cache",
25402570
"type": "timeseries"
25412571
},
25422572
{

0 commit comments

Comments
 (0)