Prisma 6 compatibility, with working tests (help required)#478
Draft
RubenNL wants to merge 3 commits intoMichalLytek:mainfrom
Draft
Prisma 6 compatibility, with working tests (help required)#478RubenNL wants to merge 3 commits intoMichalLytek:mainfrom
RubenNL wants to merge 3 commits intoMichalLytek:mainfrom
Conversation
Closed
|
Any updates on this review |
1 similar comment
|
Any updates on this review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
createManyAndReturn(this was already in 5.14.0, but the snapshots didn't have them yet)array_starts_with,array_ends_withandarray_containschanged somewhere, so the snapshots have been updated. Not a functional change.limitonDeleteManyandUpdateMany.Workflow
This is how i approached this PR:
FieldType, which I resolved in/src/generator/dmmf/types.ts.createManyAndReturnwas mentioned, I also addedupdateManyAndReturn.ScalarRelationFiltertosrc/generator/helpers.ts. I'm not sure about this last change.uafter running all the tests.A bit harder where the integration tests. For those a working Postgres database is required:
sudo docker run --rm --name some-postgres -e POSTGRES_PASSWORD=mysecretpassword -e POSTGRES_DB=testing -d -p 5432:5432 postgres.envfile withTEST_DATABASE_URL=postgresql://postgres:mysecretpassword@localhost:5432/testing.npm run test:integrationu. The changes is the same as mentioned above.Test results
Because I can't run tests on this repo, I also created a MR on my own repo to test my changes: RubenNL#1.
Help required
Most/all
*ModelRelationFilterhave been renamed to*ModelScalarRelationFilter. I can't figure out why, or how to undo this change.Related: I had to add
ScalarRelationtosrc/generator/helpers.ts, because otherwise the "renamed" tests failed.