Skip to content

Ready for Prisma 7#492

Open
mo-fouad wants to merge 4 commits intoMichalLytek:mainfrom
mo-fouad:main
Open

Ready for Prisma 7#492
mo-fouad wants to merge 4 commits intoMichalLytek:mainfrom
mo-fouad:main

Conversation

@mo-fouad
Copy link
Copy Markdown

Hey,
I have created minimal work to make the package work with Prisma 7.
I have tested it in my project, and it generates correctly.

- Removed lib/ from .gitignore to commit compiled code
- This ensures GitHub installs work without needing TypeScript as devDependency
- Fixes ENOENT error when installing from GitHub
@mo-fouad mo-fouad changed the title trying to upgrade packs Ready for Prisma 7 Jan 12, 2026
@mo-fouad mo-fouad mentioned this pull request Jan 12, 2026
Comment thread package.sh

echo "Adjusting package.json..."
sed -i 's/"private": true/"private": false/' ./package/package.json
sed -i '' 's/"private": true/"private": false/' ./package/package.json
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why such change?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was because I was testing and building on macOS, not Linux.
Please note, I was able to use it with Prisma 7 on my current project by building and installing it locally like this
"typegraphql-prisma": "link:/xx/xx/xx/type-gql/typegraphql-prisma"

If you think I should revert it, I would be happy to do so :)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this review going?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fouad please try this should work on linux and mac

sed -i.bak 's/"private": true/"private": false/' ./package/package.json
rm ./package/package.json.bak

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mo-fouad we need to move forward and let your work shine :)

@mo-fouad mo-fouad requested a review from MichalLytek January 13, 2026 13:30
@ethandaniel
Copy link
Copy Markdown

@MichalLytek can you please release a version for Prisma 7. Need it as soon as possible. Lmk if I can help in any way?

@omarragi
Copy link
Copy Markdown

@MichalLytek please :)

@omarragi
Copy link
Copy Markdown

omarragi commented Mar 6, 2026

@mo-fouad @alacret @MichalLytek
What do we need to do to move this forward?
Why taking so long? To review few file changes?

@omarragi
Copy link
Copy Markdown

Any updates ?

@alberturria
Copy link
Copy Markdown

I don't know if I can be of any help here, but would love to let this move forward.
I could try to test it also on my project, to see if it also generates correctly the types here.

@omarragi
Copy link
Copy Markdown

@MichalLytek and @mo-fouad any update, we need this asap

@wmhartl
Copy link
Copy Markdown

wmhartl commented Apr 7, 2026

Interested in getting this PR merged also @MichalLytek - is there something we can do to assist?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants