update: support prisma version 6.19#494
Open
anyuan-chen wants to merge 3 commits intoMichalLytek:mainfrom
Open
update: support prisma version 6.19#494anyuan-chen wants to merge 3 commits intoMichalLytek:mainfrom
anyuan-chen wants to merge 3 commits intoMichalLytek:mainfrom
Conversation
anyuan-chen
commented
Mar 3, 2026
| cwdDirPath + "/generated/type-graphql", | ||
| ); | ||
|
|
||
| expect(prismaGenerateResult.stderr).toHaveLength(0); |
Author
There was a problem hiding this comment.
Prisma is really annoying here, we have:
https://github.com/prisma/prisma/blob/8659f92d08d39470565db36f8b29a82bac8cec5e/packages/cli/src/Generate.ts#L159
with this error
https://github.com/prisma/prisma/blob/8659f92d08d39470565db36f8b29a82bac8cec5e/packages/internals/src/utils/tryLoadEnvs.ts#L139
so this test no longer works
anyuan-chen
commented
Mar 3, 2026
| .replace("UpdateMany", "") | ||
| .replace("AndReturnOutputType", ""), | ||
| ); | ||
| return `UpdateManyAndReturn${modelTypeName}`; |
anyuan-chen
commented
Mar 3, 2026
| createOneUser(data: UserCreateInput): User! | ||
| deleteManyPost(where: PostWhereInput): AffectedRowsOutput! | ||
| deleteManyUser(where: UserWhereInput): AffectedRowsOutput! | ||
| deleteManyPost(limit: Int, where: PostWhereInput): AffectedRowsOutput! |
| updateManyUser(data: UserUpdateManyMutationInput!, where: UserWhereInput): AffectedRowsOutput! | ||
| updateManyAndReturnPost(data: PostUpdateManyMutationInput!, limit: Int, where: PostWhereInput): [UpdateManyAndReturnPost!]! | ||
| updateManyAndReturnUser(data: UserUpdateManyMutationInput!, limit: Int, where: UserWhereInput): [UpdateManyAndReturnUser!]! | ||
| updateManyPost(data: PostUpdateManyMutationInput!, limit: Int, where: PostWhereInput): AffectedRowsOutput! |
Author
|
@MichalLytek Please take a look! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the DMMF generation to support DMMF outputted from Prisma 6.19. It also adds supports for the new clients and aliasing Prisma introduced since ver 5.
I use this project as part of Hack the North, a student run hackathon, and our backend is coupled extremely tightly to this framework and GQL as a whole. We've been on Prisma 5 for a while and would like to move to Prisma 6, which is why I am sending this patch.
I spent a decent amount of time reading DMMF and this repo to familarize myself with the general structure/logic behind generation, so I could police my coding agent when I was using it.
AI Usage:
This final PR was constructed with the help of agents, with careful and thoughtful human supervision.
My approach was to find the 2 commits where Prisma 5 left off, then find out where 6.19 was. For each of the commits, I asked the agent to collect the changes in the DMMF, and write it to a SQL db with the commit hash. I then had another coding agent go over each of those hashes and scan this repo for areas where it could apply changes.
I then confirmed the changes myself by hand in the main Prisma repo by looking at the PRs. I looked for tests to add where I felt appropriate, and instructed the agent to add them.
I did not update experiments or examples.