Fixes setup.py to include config file in whl#44
Open
sherjeelshabih wants to merge 1 commit into
Open
Conversation
|
Hi @MicheleCotrufo, it would be great if you could have a quick look at this PR. Thank you! ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
Thanks for maintaining pdf2doi! I’ve been using it recently and found it really useful.
I ran into an issue when installing from the wheel in an environment where the user does not have write access to the site-packages directory. In that case, settings.ini needs to be present at install time, but it wasn’t being included in the .whl, even though it’s listed in MANIFEST.in. If it's not present, then we get that permission error when creating the file. This is somewhat related to #29 and #30 as well.
After a bit of digging, I found that setting include_package_data=True in the package configuration fixes the problem and ensures the file makes it into the .whl and avoids runtime issues in read-only installations.
This PR adds that flag so the wheel distribution matches the intended package contents.
Happy to tweak anything if there’s a preferred packaging approach. Thanks again for the project!