fix: harden plugin source intake

Author: Microck

.gitignore

@@ -22,3 +22,6 @@ dist-ssr
 *.njsproj
 *.sln
 *.sw?
+
+# dora code context index
+.dora/

README.md

@@ -80,9 +80,9 @@ src-tauri/target/release/bundle/deb/
 
 | step | behavior |
 | --- | --- |
-| add plugin | register a local source file, local plugin folder, or HTTPS GitHub repo after validating the Vencord plugin entrypoint |
+| add plugin | paste or drop a local source file, local plugin folder, or HTTPS GitHub repo after validating the Vencord plugin entrypoint |
 | build | clone or update `Vendicated/Vencord`, recreate `src/userplugins`, run `pnpm install --frozen-lockfile`, then `pnpm build` |
-| validate | require `package.json`, `vencordDesktopMain.js`, `vencordDesktopPreload.js`, `vencordDesktopRenderer.js`, `vencordDesktopRenderer.css` |
+| validate | require `vencordDesktopMain.js`, `vencordDesktopPreload.js`, `vencordDesktopRenderer.js`, `vencordDesktopRenderer.css` |
 | apply | write the validated `dist` path to Vesktop `state.json` as `vencordDir` |
 | startup check | optionally launch at login, check the managed Vencord checkout, and rebuild/apply only when Auto rebuild is enabled |
 | restart | fully restart Vesktop so it loads the custom Vencord build |

package.json

@@ -1,7 +1,7 @@
 {
   "name": "veskforge",
   "private": true,
-  "version": "0.1.13",
+  "version": "0.1.14",
   "description": "Unofficial custom Vencord build manager for Vesktop.",
   "license": "MIT",
   "type": "module",

src-tauri/Cargo.lock

@@ -1,6 +1,6 @@
 [package]
 name = "veskforge"
-version = "0.1.13"
+version = "0.1.14"
 description = "Unofficial custom Vencord build manager for Vesktop."
 authors = ["Microck"]
 license = "MIT"

src-tauri/Cargo.toml

@@ -12,8 +12,7 @@ use tauri::{AppHandle, Manager};
 
 const VENCORD_REPO: &str = "https://github.com/Vendicated/Vencord.git";
 const MANIFEST_FILE: &str = "manifest.json";
-const REQUIRED_DIST_FILES: [&str; 5] = [
-    "package.json",
+const REQUIRED_DIST_FILES: [&str; 4] = [
     "vencordDesktopMain.js",
     "vencordDesktopPreload.js",
     "vencordDesktopRenderer.js",
@@ -274,8 +273,21 @@ fn plugin_name_from_source(source: &PluginSource, fallback: Option<String>) -> S
     }
 }
 
+fn trim_wrapping_quotes(input: &str) -> String {
+    let trimmed = input.trim();
+    if trimmed.len() >= 2 {
+        let bytes = trimmed.as_bytes();
+        let first = bytes[0];
+        let last = bytes[bytes.len() - 1];
+        if (first == b'"' && last == b'"') || (first == b'\'' && last == b'\'') {
+            return trimmed[1..trimmed.len() - 1].trim().to_string();
+        }
+    }
+    trimmed.to_string()
+}
+
 fn normalize_github_plugin_url(url: &str) -> Result<String, String> {
-    let trimmed = url.trim();
+    let trimmed = trim_wrapping_quotes(url);
     let without_scheme = trimmed
         .strip_prefix("https://github.com/")
         .ok_or_else(|| "Git plugin sources must be HTTPS GitHub repository URLs.".to_string())?;
@@ -1063,10 +1075,12 @@ fn get_environment_status(app: AppHandle) -> Result<EnvironmentStatus, String> {
 fn add_plugin(app: AppHandle, request: AddPluginRequest) -> Result<Manifest, String> {
     let source = match request.source {
         PluginSource::LocalFile { path } => {
+            let path = trim_wrapping_quotes(&path);
             validate_local_plugin_path(Path::new(&path))?;
             PluginSource::LocalFile { path }
         }
         PluginSource::LocalFolder { path } => {
+            let path = trim_wrapping_quotes(&path);
             validate_local_plugin_path(Path::new(&path))?;
             PluginSource::LocalFolder { path }
         }
@@ -1430,6 +1444,32 @@ mod tests {
         );
     }
 
+    #[test]
+    fn source_inputs_trim_wrapping_quotes() {
+        assert_eq!(
+            trim_wrapping_quotes(r#""D:\Descargas\jn v2\discord-gfm-tables.plugin.js""#),
+            r#"D:\Descargas\jn v2\discord-gfm-tables.plugin.js"#
+        );
+        assert_eq!(
+            normalize_github_plugin_url("'https://github.com/Microck/discord-gfm-tables'").unwrap(),
+            "https://github.com/Microck/discord-gfm-tables.git"
+        );
+    }
+
+    #[test]
+    fn dist_validation_matches_current_vencord_desktop_outputs() {
+        let dir = env::temp_dir().join(format!("veskforge-dist-test-{}", now_stamp()));
+        fs::create_dir_all(&dir).unwrap();
+        for file in REQUIRED_DIST_FILES {
+            fs::write(dir.join(file), "").unwrap();
+        }
+
+        assert!(validate_dist(&dir).is_ok());
+        assert!(!REQUIRED_DIST_FILES.contains(&"package.json"));
+
+        fs::remove_dir_all(dir).unwrap();
+    }
+
     #[test]
     fn materialized_plugin_requires_index_entrypoint() {
         let dir = env::temp_dir().join(format!("veskforge-entrypoint-test-{}", now_stamp()));

src-tauri/src/lib.rs

@@ -1,7 +1,7 @@
 {
   "$schema": "https://schema.tauri.app/config/2",
   "productName": "Veskforge",
-  "version": "0.1.13",
+  "version": "0.1.14",
   "identifier": "dev.micr.veskforge",
   "build": {
     "beforeDevCommand": "pnpm dev",

src-tauri/tauri.conf.json

@@ -496,6 +496,9 @@ button:disabled {
   color: #f4f5f8;
   background: rgba(18, 22, 28, 0.46);
   font-size: 16px;
+  transition:
+    border-color 160ms var(--ease),
+    background 160ms var(--ease);
 }
 
 .drop-panel > span {
@@ -508,6 +511,13 @@ button:disabled {
   padding: 14px;
 }
 
+.drop-panel.drag-active {
+  border-color: rgba(236, 118, 151, 0.72);
+  background:
+    linear-gradient(180deg, rgba(236, 118, 151, 0.12), rgba(236, 118, 151, 0.04)),
+    rgba(18, 22, 28, 0.7);
+}
+
 .source-feedback {
   display: flex;
   align-items: flex-start;