Add deprecation note for with statement in item charges example#3562
Open
jeffreybulanadi wants to merge 1 commit into
Open
Add deprecation note for with statement in item charges example#3562jeffreybulanadi wants to merge 1 commit into
jeffreybulanadi wants to merge 1 commit into
Conversation
Contributor
|
Learn Build status updates of commit 04ad446: ✅ Validation status: passed
For more details, please refer to the build report. |
jeffreybulanadi
force-pushed
the
fix-item-charges-with-deprecation-note
branch
from
04ad446 to
b228191
Compare
Contributor
|
Learn Build status updates of commit b228191: ✅ Validation status: passed
For more details, please refer to the build report. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add deprecation note for with statement usage in the item charge distribution example.
devenv-extending-item-charges.md: The GetItemValues procedure in the walkthrough uses a with statement (with TempItemChargeAssgntPurch do) with no indication it is deprecated. The with statement has been deprecated since Business Central 2020 release wave 2 (AL0606 warning). Without a note, developers copy this pattern into new code and immediately get deprecation warnings.
Added a NOTE callout before the code block pointing to the deprecating-with-statements-overview article.