Skip to content

Correct Shopify event subscriber signatures in extensibility code examples #3574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jswymer merged 4 commits into from
May 19, 2026
Merged

Correct Shopify event subscriber signatures in extensibility code examples #3574

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6da3aba
Fix OnBeforeCreateSalesHeader subscriber signature in devenv-extendin…
jeffreybulanadi May 15, 2026
72b1575
Fix OnBeforeCalculateUnitPrice and OnAfterCalculateUnitPrice missing …
jeffreybulanadi May 15, 2026
2a58b54
Replace sensitive term whitelisted with allowlisted in authentication…
jeffreybulanadi May 15, 2026
3252b9f
Update devenv-extending-shopify.md
jswymer May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions dev-itpro/developer/devenv-extending-shopify.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ The following example shows how to check whether a Shopify order is ready to be
codeunit 50107 "Shpfy Order Check Pay. Method"
{
[EventSubscriber(ObjectType::Codeunit, Codeunit::"Shpfy Order Events", OnBeforeCreateSalesHeader, '', false, false)]
internal procedure OnBeforeCreateSalesHeader(ShopifyOrderHeader: Record "Shpfy Order Header"; var SalesHeader: Record "Sales Header"; var Handled: Boolean)
internal procedure OnBeforeCreateSalesHeader(ShopifyOrderHeader: Record "Shpfy Order Header"; var SalesHeader: Record "Sales Header"; var LastCreatedDocumentId: Guid; var Handled: Boolean)
begin
ShopifyOrderHeader.Testfield("Payment Method Code");
end;
Expand Down Expand Up @@ -527,7 +527,7 @@ The following example shows how to implement logic for defining prices.
codeunit 50105 "Shpfy Custom Price"
{
[EventSubscriber(ObjectType::Codeunit, Codeunit::"Shpfy Product Events", OnBeforeCalculateUnitPrice, '', false, false)]
procedure BeforeCalculateUnitPrice(Item: Record Item; VariantCode: Code[20]; UnitOfMeasure: Code[20]; ShopifyShop: Record "Shpfy Shop"; var UnitCost: Decimal; var Price: Decimal; var ComparePrice: Decimal; var Handled: Boolean)
procedure BeforeCalculateUnitPrice(Item: Record Item; VariantCode: Code[20]; UnitOfMeasure: Code[20]; ShopifyShop: Record "Shpfy Shop"; Catalog: Record "Shpfy Catalog"; var UnitCost: Decimal; var Price: Decimal; var ComparePrice: Decimal; var Handled: Boolean)
var
CurrExchRate: Record "Currency Exchange Rate";
ItemUOM: Record "Item Unit of Measure";
Expand Down Expand Up @@ -556,7 +556,7 @@ The following example shows how to implement logic for defining compare-at price
codeunit 50110 "Shpfy Custom Compare Price"
{
[EventSubscriber(ObjectType::Codeunit, Codeunit::"Shpfy Product Events", OnAfterCalculateUnitPrice, '', false, false)]
procedure AfterCalculateUnitPrice(Item: Record Item; VariantCode: Code[20]; UnitOfMeasure: Code[20]; ShopifyShop: Record "Shpfy Shop"; var UnitCost: Decimal; var Price: Decimal; var ComparePrice: Decimal)
procedure AfterCalculateUnitPrice(Item: Record Item; VariantCode: Code[20]; UnitOfMeasure: Code[20]; ShopifyShop: Record "Shpfy Shop"; Catalog: Record "Shpfy Catalog"; var UnitCost: Decimal; var Price: Decimal; var ComparePrice: Decimal)
begin
ComparePrice := Round(Price * 1.3, 1);
Price := Round(Price, 1) - 0.05;
Expand Down