Fix DO_NOT_EDIT detection in PR labeler workflow#3577
Merged
Conversation
The non-greedy regex matched prematurely on the instructional comment line containing 'the END>DO_NOT_EDIT' instead of the actual closing marker. Fixed by requiring the closing marker prefix (IMPORTANT: or <!--). Also checks both added AND removed lines against the block content for more reliable detection. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
Learn Build status updates of commit 7470fd4: ✅ Validation status: passed
For more details, please refer to the build report. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The PR labeler workflow failed to apply the
edits-auto-generatedlabel on PRs that modify content inside DO_NOT_EDIT sections (e.g., PR #3576).Root cause
The regex
/(START>DO_NOT_EDIT)([\s\S]*?)(END>DO_NOT_EDIT)/gused a non-greedy match that terminated prematurely at the instructional comment line:markdown [//]: # (IMPORTANT:Do not edit any of the content between here and the END>DO_NOT_EDIT.)This line contains
END>DO_NOT_EDITas plain text, so the regex captured only the 2-line header instead of the full protected block.Fix
IMPORTANT:or<!--) beforeEND>DO_NOT_EDIT:js /START>DO_NOT_EDIT[\s\S]*?(?:IMPORTANT: END>DO_NOT_EDIT|<!-- END>DO_NOT_EDIT)/g