Skip to content

Update several *-FileShareAccess docs: mention that SMB share and file system security is adjusted#3495

Open
DavisNT wants to merge 2 commits into
MicrosoftDocs:mainfrom
DavisNT:shareaccess
Open

Update several *-FileShareAccess docs: mention that SMB share and file system security is adjusted#3495
DavisNT wants to merge 2 commits into
MicrosoftDocs:mainfrom
DavisNT:shareaccess

Conversation

@DavisNT

@DavisNT DavisNT commented Jun 2, 2023

Copy link
Copy Markdown

PR Summary

Update:

  • Block-FileShareAccess.md
  • Grant-FileShareAccess.md
  • Revoke-FileShareAccess.md
  • Unblock-FileShareAccess.md

Mention that security descriptors of the SMB share and the underlying file system folder are adjusted by these commands.
Add links to corresponding *-SmbShareAccess commands.

PR Checklist

  • Descriptive Title: This PR's title is a synopsis of the changes it proposes.
  • Summary: This PR's summary describes the scope and intent of the change.
  • Contributor's Guide: I have read the contributors guide.
  • Style: This PR adheres to the style guide.

@learn-build-service-prod

Copy link
Copy Markdown
Contributor

Learn Build status updates of commit 4faf9c0:

✅ Validation status: passed

File Status Preview URL Details
docset/winserver2016-ps/storage/Block-FileShareAccess.md ✅Succeeded View (WindowsServer2016-ps)
docset/winserver2016-ps/storage/Grant-FileShareAccess.md ✅Succeeded View (WindowsServer2016-ps)
docset/winserver2016-ps/storage/Revoke-FileShareAccess.md ✅Succeeded View (WindowsServer2016-ps)
docset/winserver2016-ps/storage/Unblock-FileShareAccess.md ✅Succeeded View (WindowsServer2016-ps)
docset/winserver2019-ps/storage/Block-FileShareAccess.md ✅Succeeded View (WindowsServer2019-ps)
docset/winserver2019-ps/storage/Grant-FileShareAccess.md ✅Succeeded View (WindowsServer2019-ps)
docset/winserver2019-ps/storage/Revoke-FileShareAccess.md ✅Succeeded View (WindowsServer2019-ps)
docset/winserver2019-ps/storage/Unblock-FileShareAccess.md ✅Succeeded View (WindowsServer2019-ps)
docset/winserver2022-ps/storage/Block-FileShareAccess.md ✅Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/storage/Grant-FileShareAccess.md ✅Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/storage/Revoke-FileShareAccess.md ✅Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/storage/Unblock-FileShareAccess.md ✅Succeeded View (WindowsServer2022-ps)

For more details, please refer to the build report.

For any questions, please:

@DavisNT

DavisNT commented Jun 2, 2023

Copy link
Copy Markdown
Author

@microsoft-github-policy-service agree

@JohanFreelancer9 JohanFreelancer9 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy review.

@scanum

scanum commented Jul 27, 2023

Copy link
Copy Markdown

@DavisNT

@learn-build-service-prod

Copy link
Copy Markdown
Contributor

Learn Build status updates of commit 3a72131:

✅ Validation status: passed

File Status Preview URL Details
docset/winserver2016-ps/storage/Block-FileShareAccess.md ✅Succeeded View (WindowsServer2016-ps)
docset/winserver2016-ps/storage/Grant-FileShareAccess.md ✅Succeeded View (WindowsServer2016-ps)
docset/winserver2016-ps/storage/Revoke-FileShareAccess.md ✅Succeeded View (WindowsServer2016-ps)
docset/winserver2016-ps/storage/Unblock-FileShareAccess.md ✅Succeeded View (WindowsServer2016-ps)
docset/winserver2019-ps/storage/Block-FileShareAccess.md ✅Succeeded View (WindowsServer2019-ps)
docset/winserver2019-ps/storage/Grant-FileShareAccess.md ✅Succeeded View (WindowsServer2019-ps)
docset/winserver2019-ps/storage/Revoke-FileShareAccess.md ✅Succeeded View (WindowsServer2019-ps)
docset/winserver2019-ps/storage/Unblock-FileShareAccess.md ✅Succeeded View (WindowsServer2019-ps)
docset/winserver2022-ps/storage/Block-FileShareAccess.md ✅Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/storage/Grant-FileShareAccess.md ✅Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/storage/Revoke-FileShareAccess.md ✅Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/storage/Unblock-FileShareAccess.md ✅Succeeded View (WindowsServer2022-ps)

For more details, please refer to the build report.

For any questions, please:

@DavisNT

DavisNT commented Jul 27, 2023

Copy link
Copy Markdown
Author

@scanum I have rebased this PR.
Is there anything else I should do?

Update:
* Block-FileShareAccess.md
* Grant-FileShareAccess.md
* Revoke-FileShareAccess.md
* Unblock-FileShareAccess.md

Mention that security descriptors of SMB share and underlying file system folder are adjusted.
Add links to corresponding *-SmbShareAccess docs.
@learn-build-service-prod

Copy link
Copy Markdown
Contributor

Learn Build status updates of commit aaa66da:

✅ Validation status: passed

File Status Preview URL Details
docset/winserver2016-ps/storage/Block-FileShareAccess.md ✅Succeeded View (WindowsServer2016-ps)
docset/winserver2016-ps/storage/Grant-FileShareAccess.md ✅Succeeded View (WindowsServer2016-ps)
docset/winserver2016-ps/storage/Revoke-FileShareAccess.md ✅Succeeded View (WindowsServer2016-ps)
docset/winserver2016-ps/storage/Unblock-FileShareAccess.md ✅Succeeded View (WindowsServer2016-ps)
docset/winserver2019-ps/storage/Block-FileShareAccess.md ✅Succeeded View (WindowsServer2019-ps)
docset/winserver2019-ps/storage/Grant-FileShareAccess.md ✅Succeeded View (WindowsServer2019-ps)
docset/winserver2019-ps/storage/Revoke-FileShareAccess.md ✅Succeeded View (WindowsServer2019-ps)
docset/winserver2019-ps/storage/Unblock-FileShareAccess.md ✅Succeeded View (WindowsServer2019-ps)
docset/winserver2022-ps/storage/Block-FileShareAccess.md ✅Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/storage/Grant-FileShareAccess.md ✅Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/storage/Revoke-FileShareAccess.md ✅Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/storage/Unblock-FileShareAccess.md ✅Succeeded View (WindowsServer2022-ps)

For more details, please refer to the build report.

For any questions, please:

@scanum scanum assigned ghost , get-itips and scanum Aug 1, 2023
@scanum

scanum commented Aug 6, 2023

Copy link
Copy Markdown

Hi @tiburd hope all is well. Could you please help with this PR? Thanks!

@learn-build-service-prod

Copy link
Copy Markdown
Contributor

Learn Build status updates of commit 27dcce4:

✅ Validation status: passed

File Status Preview URL Details
docset/winserver2016-ps/storage/Block-FileShareAccess.md ✅Succeeded View (WindowsServer2016-ps)
docset/winserver2016-ps/storage/Grant-FileShareAccess.md ✅Succeeded View (WindowsServer2016-ps)
docset/winserver2016-ps/storage/Revoke-FileShareAccess.md ✅Succeeded View (WindowsServer2016-ps)
docset/winserver2016-ps/storage/Unblock-FileShareAccess.md ✅Succeeded View (WindowsServer2016-ps)
docset/winserver2019-ps/storage/Block-FileShareAccess.md ✅Succeeded View (WindowsServer2019-ps)
docset/winserver2019-ps/storage/Grant-FileShareAccess.md ✅Succeeded View (WindowsServer2019-ps)
docset/winserver2019-ps/storage/Revoke-FileShareAccess.md ✅Succeeded View (WindowsServer2019-ps)
docset/winserver2019-ps/storage/Unblock-FileShareAccess.md ✅Succeeded View (WindowsServer2019-ps)
docset/winserver2022-ps/storage/Block-FileShareAccess.md ✅Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/storage/Grant-FileShareAccess.md ✅Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/storage/Revoke-FileShareAccess.md ✅Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/storage/Unblock-FileShareAccess.md ✅Succeeded View (WindowsServer2022-ps)

For more details, please refer to the build report.

For any questions, please:

@tiburd tiburd requested a review from get-itips August 7, 2023 17:29
@DavisNT

DavisNT commented Sep 17, 2023

Copy link
Copy Markdown
Author

@scanum, @tiburd, @get-itips Is there anything I can help with to get this PR reviewed and merged?

@tiburd

tiburd commented Sep 18, 2023

Copy link
Copy Markdown
Contributor

@get-itips
Hi Andres,
Please review this PR, then @ mention me after you approve.
Thank you!

@tiburd

tiburd commented Sep 18, 2023

Copy link
Copy Markdown
Contributor

@scanum, @tiburd, @get-itips Is there anything I can help with to get this PR reviewed and merged?

@DavisNT
Hi Davis,

Thank you for @ mentioning us.

There is no action for you to take on this pull request at this time.

When Andres reviews this pull request, he may have changes for you to approve or make.

After he approves, I'll merge the pull request.

Thanks!

@tiburd tiburd unassigned ghost Sep 19, 2023
@get-itips

Copy link
Copy Markdown
Contributor

I think @JasonGerend should be included as reviewer as it is the designated author of these articles

@DavisNT

DavisNT commented Sep 24, 2023

Copy link
Copy Markdown
Author

I think @JasonGerend should be included as reviewer as it is the designated author of these articles

@tiburd Can you please check @get-itips's answer?

@tiburd tiburd requested a review from JasonGerend September 25, 2023 17:58
@DavisNT

DavisNT commented Oct 10, 2023

Copy link
Copy Markdown
Author

@JasonGerend Is there anything I can help with to get this PR reviewed and merged?

@DavisNT

DavisNT commented Oct 31, 2023

Copy link
Copy Markdown
Author

@JasonGerend Could it be possible to review these changes?

@DavisNT

DavisNT commented Dec 5, 2023

Copy link
Copy Markdown
Author

@JasonGerend, @get-itips, @tiburd Could it be possible to review these changes?

@DavisNT

DavisNT commented Mar 6, 2024

Copy link
Copy Markdown
Author

@JasonGerend, Could it be possible for you to do the review?
CC: @get-itips, @tiburd

@DavisNT

DavisNT commented May 1, 2024

Copy link
Copy Markdown
Author

@tiburd Looks like this is waiting for @JasonGerend's review more than 7 months already.
Is there anything I can do to help?

@DavisNT

DavisNT commented Jul 4, 2024

Copy link
Copy Markdown
Author

@tiburd, @get-itips, @JasonGerend Is there anything I can do to help this PR getting reviewed and merged?

@DavisNT

DavisNT commented Oct 19, 2024

Copy link
Copy Markdown
Author

@tiburd, @get-itips, @JasonGerend Could it be possible to review this PR?

If I need to rebase it, please let me know!

@DavisNT

DavisNT commented Feb 20, 2025

Copy link
Copy Markdown
Author

@get-itips, @JasonGerend, @scanum, @tiburd Can you please review this PR?

@DavisNT

DavisNT commented Jun 1, 2025

Copy link
Copy Markdown
Author

@tiburd Looks like this PR has been literally stuck for years.
Is there anything I can do about it?
Should I rebase?

@DavisNT

DavisNT commented Dec 16, 2025

Copy link
Copy Markdown
Author

@get-itips, @JasonGerend, @JohanFreelancer9, @scanum, @tiburd Could I please get any response here?
Should I rebase?

@DavisNT

DavisNT commented May 25, 2026

Copy link
Copy Markdown
Author

@get-itips, @JasonGerend, @JohanFreelancer9, @scanum, @tiburd Is there anything I can do to help this PR to get reviewed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants