Improves 'RemoteAddress' description for '*-NetFirewall*' cmdlets on supported OSes#3746
Open
exchange12rocks wants to merge 2 commits into
Open
Improves 'RemoteAddress' description for '*-NetFirewall*' cmdlets on supported OSes#3746exchange12rocks wants to merge 2 commits into
exchange12rocks wants to merge 2 commits into
Conversation
…upported OSes Clearly specifies what is accepted on each operating system
Contributor
Contributor
Author
|
Dear @robinharwood, would it be possible to approve this PR too? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Clearly specifies what possible inputs for this parameter are accepted on each operating system.
Only for "*-NetFirewall*" cmdlets. Only for the currently supported OSes (WS 2016/2019/2022/2025, W10/11).
Previously some descriptions showed examples of IP address ranges in an incorrect format: "1.2.3.4 through 1.2.3.7"
I also added a new keyword "CaptivePortal" to those OS that support it (note, while W10 supports this keyword, WS2019 doesn't).
I also made sure that information about appending 4/6, using Get-NetFirewallAddressFilter appears in all these documents and is nicely formatted.
PR Checklist