Skip to content

Commit 60c61d5

Browse files
GittyHarshaCopilot
andcommitted
Address PR review comments
- Replace hardcoded ICoreWebView2Settings8 reference with link to IsReputationCheckingRequired docs, describe as per-WebView setting - Add security warning about disabling SmartScreen only for trusted origins - Restore COREWEBVIEW2_ORIGIN_FEATURE_STATE doc comment Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent e3bb6e2 commit 60c61d5

1 file changed

Lines changed: 8 additions & 3 deletions

File tree

specs/TrustedOriginSetting.md

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -219,9 +219,14 @@ typedef enum COREWEBVIEW2_ORIGIN_FEATURE {
219219
/// `Disabled` for an origin will skip SmartScreen reputation checks for
220220
/// navigations and downloads from that origin, effectively allow-listing it.
221221
///
222-
/// This configuration operates within the scope of the global SmartScreen toggle
223-
/// controlled by `ICoreWebView2Settings8.IsReputationCheckingRequired`.
224-
/// When `IsReputationCheckingRequired` is `false` (SmartScreen globally
222+
/// \warning Disabling SmartScreen for an origin removes important security
223+
/// protections. Only disable SmartScreen for fully trusted, app-controlled
224+
/// origins where the content is known to be safe.
225+
///
226+
/// This configuration operates within the scope of the per-WebView SmartScreen
227+
/// setting controlled by
228+
/// [IsReputationCheckingRequired](https://learn.microsoft.com/en-us/dotnet/api/microsoft.web.webview2.core.corewebview2settings.isreputationcheckingrequired).
229+
/// When `IsReputationCheckingRequired` is `false` (SmartScreen
225230
/// disabled), the SmartScreen check is not active and this
226231
/// per-origin configuration has no effect. When `IsReputationCheckingRequired`
227232
/// is `true` (the default), this per-origin configuration controls whether

0 commit comments

Comments
 (0)