fix(auth): use API key owner for authenticated subject to prevent admin spoofing#53
Open
Micsi wants to merge 1 commit into
Open
fix(auth): use API key owner for authenticated subject to prevent admin spoofing#53Micsi wants to merge 1 commit into
Micsi wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
api_keys.nameas the subject, allowing a non-admin to create a key namedadminand bypassget_admin_userto reach admin-only endpoints such as/api/v1/config/export/db.Description
obs/api/auth.pyget_current_usernow queriesSELECT owner FROM api_keys WHERE key_hash=?and returnsrow["owner"]instead of returning the user-controlledname, ensuring the authenticated principal is the real key owner.Testing
pytest -q tests -k "auth or api_key or config", but test collection failed in this environment becausepytest_asynciois not installed, so automated validation could not be completed here.Codex Task