fix(api): restrict MQTT sample endpoint to admins and disallow wildcard topics#56
Open
Micsi wants to merge 1 commit into
Open
fix(api): restrict MQTT sample endpoint to admins and disallow wildcard topics#56Micsi wants to merge 1 commit into
Micsi wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
GET /instances/{instance_id}/mqtt/sampleendpoint previously allowed any authenticated user to subscribe with server-side adapter credentials to an arbitrary topic, which could disclose sensitive broker payloads.Description
get_current_usertoget_admin_userinobs/api/v1/adapters.pyformqtt_sample_payloadto prevent low-privileged API keys from invoking it.obs/api/v1/adapters.pytostrip()thetopic, reject empty topics, and return HTTP 400 if the topic contains MQTT wildcard characters#or+.aiomqttis unavailable or the MQTT connection fails.Testing
python -m compileall obs/api/v1/adapters.pyand the module compiled successfully with no syntax errors.Codex Task