Problem in the Copy operation

[mc-butler]

Important

This issue was migrated from Trac:

Origin	https://midnight-commander.org/ticket/2278
Reporter	eshkrig (eshkrig@….com)
Mentions	gotar@….pl, howaboutsynergy@….me

Hi.
Sorry for my English.
Previously, copying a file does not change access permissions of the destination file if the check box "Preserve attributes" in the Copy window is not set.
For some time it is not so: if you uncheck the "Preserve attributes" then access permissions of the destination file are set in accordance with the value of umask, which can lead to information disclosure(i.e. security problem).

Note

Original attachments:

• mc-copy_chmod.diff (raw) by eshkrig (eshkrig@….com) on Jul 14, 2011 at 18:57 UTC

[mc-butler]

Changed by eshkrig (eshkrig@….com) on Sep 11, 2010 at 7:42 UTC (comment 1)

• Version changed from 4.7.3 to 4.7.4

The problem is still present in version 4.7.4

[mc-butler]

Changed by eshkrig (eshkrig@….com) on Feb 20, 2011 at 15:56 UTC (comment 2)

the problem is still there:
app-misc/mc-4.7.5.1

[mc-butler]

Changed by eshkrig (eshkrig@….com) on Apr 14, 2011 at 17:32 UTC (comment 3)

the problem is still there:
app-misc/mc-4.7.5.2

[mc-butler]

Changed by andrew_b (@aborodin) on Apr 15, 2011 at 7:29 UTC

• Description edited
• Milestone changed from 4.7 to 4.8

Replying to eshkrig (#2278):

Previously, copying a file does not change access permissions of the destination file if the check box "Preserve attributes" in the Copy window is not set. For some time it is not so: if you uncheck the "Preserve attributes" then access permissions of the destination file are setted in accordance with the value of umask,

Yes, that done in #72. But how do you think should be a difference whether "Preserve attributes" is checked or not?

[mc-butler]

Changed by eshkrig (eshkrig@….com) on Apr 16, 2011 at 7:42 UTC (comment 5)

IMHO: existing files should only get new content (as earlier versions do)

for example:
-rw------- /path_dst/dir1/secret_file # secret file with old contents
-rw-rw-r-- /path_dst/dir1/some_file

-rw------- /path_src/dir1/secret_file # secret file with new contents

when copying dir
/path_src/dir1 to /path_dst
we have got
-rw-r--r-- /path_dst/dir1/secret_file

That is fail becose structure may contain thousands of hundreds of thousands of catalogs.
And how about ACLs on /path_dst/dir1 ?

As I mention there is security bug for 9 months now (I am sad).

[mc-butler]

Changed by andrew_b (@aborodin) on Apr 16, 2011 at 8:11 UTC (comment 5.6)

Replying to eshkrig:

IMHO: existing files should only get new content (as earlier versions do)

I don't quite understand, why you check "Preserve attributes" off if you want keep permissions.

[mc-butler]

Changed by eshkrig (eshkrig@….com) on Apr 16, 2011 at 8:41 UTC (comment 6.7)

Replying to andrew_b:

I don't quite understand, why you check "Preserve attributes" off if you want keep permissions.

Because here changes the file owner and permissions.

For example as root I often have to modify configuration files in users' home directories.
Before, I could use the MC and the copy prepared files/directories to the user's home directory.

Now the situation is as follows:
If I copy the files with the "Preserve attributes" on - owner of the files is changed to root
If I copy the files with the "Preserve attributes" off - file permissions are changed to 644(-rw-r--r--) and this is not dependent on the established permissions to the source or the destination files

[mc-butler]

Changed by eshkrig (eshkrig@….com) on Jul 14, 2011 at 18:57 UTC

• Attachment mc-copy_chmod.diff (raw) added

[mc-butler]

Changed by eshkrig (eshkrig@….com) on Jul 14, 2011 at 18:58 UTC (comment 8)

• Branch state set to no branch

The patch, which fixes the problem

[mc-butler]

Changed by bradatec (ps@….jikos.cz) on Sep 23, 2011 at 6:12 UTC (comment 9)

My bug was marked as a dupe of this (#2615) although it seems to me its something different.
In short, when copying files as a root, normal files get correct file/group id but it get wrong for soft links (preserve attributes are on).

[mc-butler]

Changed by gotar (gotar@….pl) on Oct 10, 2011 at 10:38 UTC (comment 10)

• Cc set to gotar@….pl

[mc-butler]

Changed by slavazanko (@slavaz) on Mar 22, 2012 at 15:01 UTC (comment 11)

• Owner set to slavazanko
• Status changed from new to accepted

[mc-butler]

Changed by slavazanko (@slavaz) on Mar 22, 2012 at 15:59 UTC (comment 12)

• Branch state changed from no branch to on review

Created branch 2278_preserve_attrs_if_dest_exists [a58aee0]

Review, please.

[mc-butler]

Changed by slavazanko (@slavaz) on Mar 22, 2012 at 19:03 UTC (comment 13)

• Milestone changed from 4.8 to 4.8.3

[mc-butler]

Changed by andrew_b (@aborodin) on Mar 25, 2012 at 14:21 UTC (comment 14)

• Votes set to andrew_b