Merge pull request #33 from salismt/fix/snapbi-minify-json-signature

fix(snapbi): preserve whitespace in JSON string values during minification

Author: uziwuzzy

.gitignore

@@ -32,6 +32,7 @@ target/
 .classpath
 .project
 .settings
+.factorypath
 **/.checkstyle
 target/
 bin/
@@ -57,4 +58,14 @@ dist
 /.mvn/
 /mvnw
 /mvnw.bat
-mvnw.cmd
+mvnw.cmd
+
+## GitHub Copilot prompts & skills (OpenSpec-generated):
+.github/prompts/
+.github/skills/
+
+## OpenCode (AI agent config):
+.opencode/
+
+## OpenSpec (spec-driven workflow artifacts):
+openspec/

CHANGELOG.md

@@ -1,5 +1,11 @@
 ## CHANGELOG MIDTRANS JAVA LIBRARY
 
+## v3.2.2 (April 7, 2026)
+
+Bug fixes:
+- Fix `minifyJson()` in SnapBi stripping whitespace inside JSON string values, which caused incorrect SNAP-BI webhook notification signature verification. The method now uses a character-level JSON minifier that preserves whitespace within quoted strings.
+- Fix `MidtransError` getter methods not being generated by Lombok on JDK 25. Replaced `@Getter` annotation with explicit getter methods for `statusCode`, `responseBody`, and `response`.
+
 ## v3.2.1 (October 16, 2024)
 
 Feature:

example/pom.xml

@@ -44,7 +44,7 @@
         <dependency>
             <groupId>com.midtrans</groupId>
             <artifactId>java-library</artifactId>
-            <version>3.2.1</version>
+            <version>3.2.2</version>
             <scope>compile</scope>
         </dependency>
     </dependencies>

library/pom.xml

@@ -5,7 +5,7 @@
 
     <groupId>com.midtrans</groupId>
     <artifactId>java-library</artifactId>
-    <version>3.2.1</version>
+    <version>3.2.2</version>
     <packaging>jar</packaging>
 
     <name>Midtrans Java Official Library</name>

library/src/main/java/com/midtrans/httpclient/error/MidtransError.java

@@ -1,19 +1,34 @@
 package com.midtrans.httpclient.error;
 
-import lombok.Getter;
 import okhttp3.Response;
 
 /**
  * MidtransError class to catch error messages
  */
-@Getter
 public class MidtransError extends Exception {
 
     private String message;
     private Integer statusCode;
     private String responseBody;
     private Response response;
 
+    @Override
+    public String getMessage() {
+        return message;
+    }
+
+    public Integer getStatusCode() {
+        return statusCode;
+    }
+
+    public String getResponseBody() {
+        return responseBody;
+    }
+
+    public Response getResponse() {
+        return response;
+    }
+
     /**
      * Constructs a Midtrans exception with the message
      *

library/src/main/java/com/midtrans/snapbi/SnapBi.java

@@ -295,8 +295,37 @@ public static String getSymmetricSignatureHmacSh512(String accessToken, Map<Stri
     }
 
     private static String minifyJson(String json) {
-        // Minify JSON by removing whitespace
-        return json.replaceAll("\\s+", "");
+        if (json == null || json.isEmpty()) {
+            return "";
+        }
+        // Minify JSON by removing insignificant whitespace (outside of string values)
+        // while preserving whitespace inside quoted strings and maintaining key order.
+        StringBuilder sb = new StringBuilder(json.length());
+        boolean inString = false;
+        boolean escaped = false;
+        for (int i = 0; i < json.length(); i++) {
+            char c = json.charAt(i);
+            if (escaped) {
+                sb.append(c);
+                escaped = false;
+                continue;
+            }
+            if (c == '\\' && inString) {
+                sb.append(c);
+                escaped = true;
+                continue;
+            }
+            if (c == '"') {
+                inString = !inString;
+                sb.append(c);
+                continue;
+            }
+            if (!inString && Character.isWhitespace(c)) {
+                continue;
+            }
+            sb.append(c);
+        }
+        return sb.toString();
     }
 
     private static byte[] hashSha256(String input) throws NoSuchAlgorithmException {