Commit bdacc8e
committed
refactor(snapbi): address PR feedback and add fixture-based webhook tests
- Apply Copilot suggestions: @OverRide on getMessage(), StandardCharsets.UTF_8
in test helper, remove redundant toLowerCase(), fix CHANGELOG grammar
- Restore minifyJson to private visibility, test through public API only
- Replace direct minifyJson unit tests with fixture-based webhook signature
tests covering VA, QRIS, and Direct Debit (pending + success/settlement)
- Add JSON fixture files with edge cases: spaces in string values, escaped
quotes, empty objects, nested arrays1 parent adb7e2c commit bdacc8e
11 files changed
Lines changed: 312 additions & 146 deletions
File tree
- library/src
- main/java/com/midtrans
- httpclient/error
- snapbi
- test
- java/com/midtrans/snapbi
- resources/snapbi/webhook
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
| 5 | + | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| |||
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| 15 | + | |
15 | 16 | | |
16 | 17 | | |
17 | 18 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
294 | 294 | | |
295 | 295 | | |
296 | 296 | | |
297 | | - | |
| 297 | + | |
298 | 298 | | |
299 | 299 | | |
300 | 300 | | |
| |||
Lines changed: 0 additions & 97 deletions
This file was deleted.
0 commit comments