Fix duplication bug when spam clicking items around in the inventory (Fixes #84)

Author: Mikedeejay2

src/main/java/com/mikedeejay2/simplestack/listeners/player/InventoryClickListener.java

@@ -4,6 +4,7 @@
 import com.mikedeejay2.simplestack.util.CancelUtils;
 import com.mikedeejay2.simplestack.util.CheckUtils;
 import com.mikedeejay2.simplestack.util.ClickUtils;
+import com.mikedeejay2.simplestack.util.MoveUtils;
 import org.bukkit.entity.Player;
 import org.bukkit.event.EventHandler;
 import org.bukkit.event.EventPriority;
@@ -36,6 +37,11 @@ public InventoryClickListener(Simplestack plugin)
     @EventHandler(priority = EventPriority.HIGHEST, ignoreCancelled = true)
     public void stackEvent(InventoryClickEvent event)
     {
+        if(MoveUtils.doNotMove.contains(event.getWhoClicked()))
+        {
+            event.setCancelled(true);
+            return;
+        }
         Player player = (Player) event.getWhoClicked();
         InventoryAction action = event.getAction();
         CheckUtils.updateGUIManual(plugin, player.getOpenInventory().getTopInventory());

src/main/java/com/mikedeejay2/simplestack/listeners/player/InventoryDragListener.java

@@ -39,6 +39,11 @@ public InventoryDragListener(Simplestack plugin)
     @EventHandler(priority = EventPriority.HIGHEST, ignoreCancelled = true)
     public void inventoryDragEvent(InventoryDragEvent event)
     {
+        if(MoveUtils.doNotMove.contains(event.getWhoClicked()))
+        {
+            event.setCancelled(true);
+            return;
+        }
         if(event.getType() != DragType.EVEN) return;
         InventoryView inventoryView = event.getView();
         if(event.getInventory() instanceof BrewerInventory || event.getInventory() instanceof BeaconInventory) return;

src/main/java/com/mikedeejay2/simplestack/util/MoveUtils.java

@@ -18,7 +18,9 @@
 import org.bukkit.inventory.meta.BlockStateMeta;
 import org.bukkit.scheduler.BukkitRunnable;
 
+import java.util.ArrayList;
 import java.util.Arrays;
+import java.util.List;
 
 /**
  * Utilities for moving items from one location to another
@@ -27,6 +29,11 @@
  */
 public final class MoveUtils
 {
+    /**
+     * A list holding all players whose movements should not be processed
+     */
+    public static final List<Player> doNotMove = new ArrayList<>();
+
     /**
      * Emulates picking up an item that is regularly unstackable from the ground
      * and attempting to stack it with other items in the player's inventory.
@@ -419,6 +426,7 @@ public static void moveAllItemsToPlayerInv(Simplestack plugin, Inventory invToMo
      */
     public static void dragItemsSurvival(Simplestack plugin, InventoryDragEvent event, InventoryView inventoryView, Player player, ItemStack cursor)
     {
+        doNotMove.add(player);
         Integer[] slots = event.getNewItems().keySet().toArray(new Integer[0]);
         ItemStack[] newItems = event.getNewItems().values().toArray(new ItemStack[0]);
         for(int i = 0; i < slots.length; i++)
@@ -471,6 +479,7 @@ public void run()
                 ItemStack newCursor = cursor.clone();
                 newCursor.setAmount(amountLeft + finalNewExtraAmount);
                 player.setItemOnCursor(newCursor);
+                doNotMove.remove(player);
             }
         }.runTask(plugin);
     }