Skip to content

Commit 6dbdbb6

Browse files
Added UNSUPPORTED super resolution upscaler stubs to all backends
1 parent 305e4be commit 6dbdbb6

25 files changed

Lines changed: 111 additions & 6 deletions

Graphics/GraphicsEngine/src/RenderDeviceBase.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ DeviceFeatures EnableDeviceFeatures(const DeviceFeatures& SupportedFeatures,
122122
ENABLE_FEATURE(FormattedBuffers, "Formatted buffers are");
123123
// clang-format on
124124

125-
ASSERT_SIZEOF(DeviceFeatures, 47, "Did you add a new feature to DeviceFeatures? Please handle its status here (if necessary).");
125+
ASSERT_SIZEOF(DeviceFeatures, 48, "Did you add a new feature to DeviceFeatures? Please handle its status here (if necessary).");
126126

127127
return EnabledFeatures;
128128
}

Graphics/GraphicsEngineD3D11/include/DeviceContextD3D11Impl.hpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -284,6 +284,10 @@ class DeviceContextD3D11Impl final : public DeviceContextBase<EngineD3D11ImplTra
284284
SHADING_RATE_COMBINER PrimitiveCombiner,
285285
SHADING_RATE_COMBINER TextureCombiner) override final;
286286

287+
/// Implementation of IDeviceContext::ExecuteSuperResolutionUpscaler() in Direct3D11 backend.
288+
virtual void DILIGENT_CALL_TYPE ExecuteSuperResolutionUpscaler(const ExecuteSuperResolutionUpscalerAttribs& Attribs,
289+
ISuperResolutionUpscaler* pUpscaler) override final;
290+
287291
/// Implementation of IDeviceContext::BindSparseResourceMemory() in Direct3D11 backend.
288292
virtual void DILIGENT_CALL_TYPE BindSparseResourceMemory(const BindSparseResourceMemoryAttribs& Attribs) override final;
289293

Graphics/GraphicsEngineD3D11/include/RenderDeviceD3D11Impl.hpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,10 @@ class RenderDeviceD3D11Impl final : public RenderDeviceD3DBase<EngineD3D11ImplTr
111111
virtual void DILIGENT_CALL_TYPE CreateSBT(const ShaderBindingTableDesc& Desc,
112112
IShaderBindingTable** ppSBT) override final;
113113

114+
/// Implementation of IRenderDevice::CreateSuperResolutionUpscaler() in Direct3D11 backend.
115+
virtual void DILIGENT_CALL_TYPE CreateSuperResolutionUpscaler(const SuperResolutionUpscalerDesc& Desc,
116+
ISuperResolutionUpscaler** ppUpscaler) override final;
117+
114118
/// Implementation of IRenderDevice::CreatePipelineResourceSignature() in Direct3D11 backend.
115119
virtual void DILIGENT_CALL_TYPE CreatePipelineResourceSignature(const PipelineResourceSignatureDesc& Desc,
116120
IPipelineResourceSignature** ppSignature) override final;

Graphics/GraphicsEngineD3D11/src/DeviceContextD3D11Impl.cpp

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2466,6 +2466,12 @@ void DeviceContextD3D11Impl::SetShadingRate(SHADING_RATE BaseRate, SHADING_RATE_
24662466
UNSUPPORTED("SetShadingRate is not supported in DirectX 11");
24672467
}
24682468

2469+
void DeviceContextD3D11Impl::ExecuteSuperResolutionUpscaler(const ExecuteSuperResolutionUpscalerAttribs& Attribs,
2470+
ISuperResolutionUpscaler* pUpscaler)
2471+
{
2472+
UNSUPPORTED("ExecuteSuperResolutionUpscaler is not supported in DirectX 11");
2473+
}
2474+
24692475
void DeviceContextD3D11Impl::BindSparseResourceMemory(const BindSparseResourceMemoryAttribs& Attribs)
24702476
{
24712477
TDeviceContextBase::BindSparseResourceMemory(Attribs, 0);

Graphics/GraphicsEngineD3D11/src/RenderDeviceD3D11Impl.cpp

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -355,6 +355,13 @@ void RenderDeviceD3D11Impl::CreateSBT(const ShaderBindingTableDesc& Desc,
355355
*ppSBT = nullptr;
356356
}
357357

358+
void RenderDeviceD3D11Impl::CreateSuperResolutionUpscaler(const SuperResolutionUpscalerDesc& Desc,
359+
ISuperResolutionUpscaler** ppUpscaler)
360+
{
361+
UNSUPPORTED("CreateSuperResolutionUpscaler is not supported in DirectX 11");
362+
*ppUpscaler = nullptr;
363+
}
364+
358365
void RenderDeviceD3D11Impl::CreatePipelineResourceSignature(const PipelineResourceSignatureDesc& Desc,
359366
IPipelineResourceSignature** ppSignature)
360367
{

Graphics/GraphicsEngineD3D12/include/DeviceContextD3D12Impl.hpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -299,6 +299,10 @@ class DeviceContextD3D12Impl final : public DeviceContextNextGenBase<EngineD3D12
299299
SHADING_RATE_COMBINER PrimitiveCombiner,
300300
SHADING_RATE_COMBINER TextureCombiner) override final;
301301

302+
/// Implementation of IDeviceContext::ExecuteSuperResolutionUpscaler() in Direct3D12 backend.
303+
virtual void DILIGENT_CALL_TYPE ExecuteSuperResolutionUpscaler(const ExecuteSuperResolutionUpscalerAttribs& Attribs,
304+
ISuperResolutionUpscaler* pUpscaler) override final;
305+
302306
/// Implementation of IDeviceContext::BindSparseResourceMemory() in Direct3D12 backend.
303307
virtual void DILIGENT_CALL_TYPE BindSparseResourceMemory(const BindSparseResourceMemoryAttribs& Attribs) override final;
304308

Graphics/GraphicsEngineD3D12/include/RenderDeviceD3D12Impl.hpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -149,6 +149,10 @@ class RenderDeviceD3D12Impl final : public RenderDeviceNextGenBase<RenderDeviceD
149149
virtual void DILIGENT_CALL_TYPE CreateSBT(const ShaderBindingTableDesc& Desc,
150150
IShaderBindingTable** ppSBT) override final;
151151

152+
/// Implementation of IRenderDevice::CreateSuperResolutionUpscaler() in Direct3D12 backend.
153+
virtual void DILIGENT_CALL_TYPE CreateSuperResolutionUpscaler(const SuperResolutionUpscalerDesc& Desc,
154+
ISuperResolutionUpscaler** ppUpscaler) override final;
155+
152156
/// Implementation of IRenderDevice::CreatePipelineResourceSignature() in Direct3D12 backend.
153157
virtual void DILIGENT_CALL_TYPE CreatePipelineResourceSignature(const PipelineResourceSignatureDesc& Desc,
154158
IPipelineResourceSignature** ppSignature) override final;

Graphics/GraphicsEngineD3D12/src/DeviceContextD3D12Impl.cpp

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3348,4 +3348,10 @@ void DeviceContextD3D12Impl::BindSparseResourceMemory(const BindSparseResourceMe
33483348
UnlockCommandQueue();
33493349
}
33503350

3351+
void DeviceContextD3D12Impl::ExecuteSuperResolutionUpscaler(const ExecuteSuperResolutionUpscalerAttribs& Attribs,
3352+
ISuperResolutionUpscaler* pUpscaler)
3353+
{
3354+
UNSUPPORTED("ExecuteSuperResolutionUpscaler is not supported in DirectX 12");
3355+
}
3356+
33513357
} // namespace Diligent

Graphics/GraphicsEngineD3D12/src/EngineFactoryD3D12.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1106,7 +1106,7 @@ GraphicsAdapterInfo EngineFactoryD3D12Impl::GetGraphicsAdapterInfo(void*
11061106
ASSERT_SIZEOF(DrawCommandProps, 12, "Did you add a new member to DrawCommandProperties? Please initialize it here.");
11071107
}
11081108

1109-
ASSERT_SIZEOF(DeviceFeatures, 47, "Did you add a new feature to DeviceFeatures? Please handle its status here.");
1109+
ASSERT_SIZEOF(DeviceFeatures, 48, "Did you add a new feature to DeviceFeatures? Please handle its status here.");
11101110

11111111
return AdapterInfo;
11121112
}

Graphics/GraphicsEngineD3D12/src/RenderDeviceD3D12Impl.cpp

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -676,6 +676,13 @@ void RenderDeviceD3D12Impl::CreateSBT(const ShaderBindingTableDesc& Desc,
676676
CreateSBTImpl(ppSBT, Desc);
677677
}
678678

679+
void RenderDeviceD3D12Impl::CreateSuperResolutionUpscaler(const SuperResolutionUpscalerDesc& Desc,
680+
ISuperResolutionUpscaler** ppUpscaler)
681+
{
682+
UNSUPPORTED("CreateSuperResolutionUpscaler is not supported in DirectX 12");
683+
*ppUpscaler = nullptr;
684+
}
685+
679686
void RenderDeviceD3D12Impl::CreatePipelineResourceSignature(const PipelineResourceSignatureDesc& Desc,
680687
IPipelineResourceSignature** ppSignature)
681688
{

0 commit comments

Comments
 (0)